Skip to content

Commit 8990caa

Browse files
committed
chore(submitqueue): remove dead pusher extension
## Summary ### Why? The `pusher` extension is dead code. Merge execution moved to Runway, where the pluggable contract is `runway/extension/merger` — a Runway-owned interface that takes a `MergeRequest` off the queue rather than SubmitQueue `entity.Batch` values. Nothing in the tree imports `submitqueue/extension/pusher` any more: the only remaining references were the package's own files and the `mocks` target in the Makefile. Removing it now keeps a second, divergent merge contract from drifting alongside the live one. ### What? Deletes the whole `submitqueue/extension/pusher` tree — the `Pusher`/`Factory` contract, the git-backed implementation, the fake, and the generated mock. Drops `./submitqueue/extension/pusher/...` from the `go generate` invocation in the `mocks` Makefile target. Left in place it would point `make mocks` at a path that no longer exists. Drops the stale `pusher` mention from the `changeset` package docs, which listed it as an example of a decision/action extension resolving content through a `Resolver`. ## Test Plan ✅ `make gazelle` — no BUILD churn beyond the deleted packages ✅ `make fmt` ✅ `make test` — 77/77 pass ✅ `grep -rn "extension/pusher"` over the tree returns nothing
1 parent e00c689 commit 8990caa

13 files changed

Lines changed: 2 additions & 1667 deletions

File tree

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -366,7 +366,7 @@ local-stovepipe-stop: ## Stop the Stovepipe service
366366

367367
mocks: ## Generate mock files using mockgen
368368
@echo "Generating mocks..."
369-
@$(BAZEL) run @rules_go//go -- generate ./submitqueue/extension/storage/... ./submitqueue/extension/buildrunner/... ./submitqueue/extension/changeprovider/... ./platform/extension/counter/... ./platform/extension/messagequeue/... ./submitqueue/extension/queueconfig/... ./submitqueue/extension/mergechecker/... ./submitqueue/extension/pusher/... ./submitqueue/extension/scorer/... ./submitqueue/extension/conflict/... ./submitqueue/extension/validator/... ./platform/consumer/... ./stovepipe/extension/storage/... ./stovepipe/extension/sourcecontrol/...
369+
@$(BAZEL) run @rules_go//go -- generate ./submitqueue/extension/storage/... ./submitqueue/extension/buildrunner/... ./submitqueue/extension/changeprovider/... ./platform/extension/counter/... ./platform/extension/messagequeue/... ./submitqueue/extension/queueconfig/... ./submitqueue/extension/mergechecker/... ./submitqueue/extension/scorer/... ./submitqueue/extension/conflict/... ./submitqueue/extension/validator/... ./platform/consumer/... ./stovepipe/extension/storage/... ./stovepipe/extension/sourcecontrol/...
370370
@echo "Mocks generated successfully!"
371371

372372
proto: ## Generate protobuf files from .proto definitions

submitqueue/core/changeset/changeset.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
// Package changeset resolves batch identity into the changes a batch contains.
1616
// It is the single place the orchestrator walks batch -> requests -> changes,
1717
// consolidating what the build and merge controllers each did privately.
18-
// Decision/action extensions (scorer, buildrunner, pusher, and future
18+
// Decision/action extensions (scorer, buildrunner, and future
1919
// detail-aware conflict analyzers) take thin identity entities and resolve their
2020
// granular content through an injected Resolver instead of being handed
2121
// pre-resolved data by a controller.

submitqueue/extension/pusher/BUILD.bazel

Lines changed: 0 additions & 9 deletions
This file was deleted.

submitqueue/extension/pusher/README.md

Lines changed: 0 additions & 57 deletions
This file was deleted.

submitqueue/extension/pusher/fake/BUILD.bazel

Lines changed: 0 additions & 29 deletions
This file was deleted.

submitqueue/extension/pusher/fake/fake.go

Lines changed: 0 additions & 100 deletions
This file was deleted.

submitqueue/extension/pusher/fake/fake_test.go

Lines changed: 0 additions & 68 deletions
This file was deleted.

submitqueue/extension/pusher/git/BUILD.bazel

Lines changed: 0 additions & 48 deletions
This file was deleted.

0 commit comments

Comments
 (0)