Skip to content

Commit 90cbeef

Browse files
committed
refactor(stovepipe): rename BuildStrategy full_monorepo to full
Align entity and storage contract tests with review feedback to use "full" instead of "monorepo" for the whole-repo build strategy.
1 parent 6d52545 commit 90cbeef

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

stovepipe/entity/request.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,8 @@ const (
4646
BuildStrategyUnknown BuildStrategy = ""
4747
// BuildStrategyIncrementalSinceGreen validates only the delta since the pinned baseline URI.
4848
BuildStrategyIncrementalSinceGreen BuildStrategy = "incremental_since_green"
49-
// BuildStrategyFullMonorepo validates the whole monorepo from scratch.
50-
BuildStrategyFullMonorepo BuildStrategy = "full_monorepo"
49+
// BuildStrategyFull validates the whole repo from scratch.
50+
BuildStrategyFull BuildStrategy = "full"
5151
)
5252

5353
// Request represents a single validation of a queue at a particular commit. The queue reports
@@ -75,7 +75,7 @@ type Request struct {
7575
// BuildStrategy is the validation scope process chose when admitting this request.
7676
BuildStrategy BuildStrategy `json:"build_strategy"`
7777
// BaseURI is the base URI to be used for this request when the strategy is incremental.
78-
// Empty for full-monorepo builds and cold start.
78+
// Empty for full builds and cold start.
7979
BaseURI string `json:"base_uri"`
8080

8181
// ****************

test/integration/stovepipe/extension/storage/mysql/storage_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -130,14 +130,14 @@ func (s *MySQLRequestStoreSuite) TestUpdateCAS() {
130130
updated := req
131131
updated.URI = "git://remote/monorepo/main/resolved"
132132
updated.State = entity.RequestStateProcessing
133-
updated.BuildStrategy = entity.BuildStrategyFullMonorepo
133+
updated.BuildStrategy = entity.BuildStrategyFull
134134
require.NoError(s.T(), s.store.Update(s.ctx, updated, 1, 2))
135135

136136
got, err := s.store.Get(s.ctx, req.ID)
137137
require.NoError(s.T(), err)
138138
require.Equal(s.T(), "git://remote/monorepo/main/resolved", got.URI)
139139
require.Equal(s.T(), entity.RequestStateProcessing, got.State)
140-
require.Equal(s.T(), entity.BuildStrategyFullMonorepo, got.BuildStrategy)
140+
require.Equal(s.T(), entity.BuildStrategyFull, got.BuildStrategy)
141141
require.Equal(s.T(), int32(2), got.Version)
142142

143143
// Stale CAS: oldVersion 1 no longer matches the stored version (2).

0 commit comments

Comments
 (0)