fix(client): show a failed request's reason in the run summary

The final "N request(s) did not land" line printed only id=status, so a failure read as "demo-queue/630=error" with no reason — even once the orchestrator began recording one on the request's terminal log. Append the request's last error to each failed entry when it has one, so a watched or scripted run reports why a change did not land, not only that it did not.

Author: behinddwalls

submitqueue/client/view.go

@@ -272,7 +272,11 @@ func summarize(rows []*Row) error {
 	var failed []string
 	for _, rw := range rows {
 		if rw.Status != string(entity.RequestStatusLanded) {
-			failed = append(failed, fmt.Sprintf("%s=%s", rw.SQID, rw.Status))
+			entry := fmt.Sprintf("%s=%s", rw.SQID, rw.Status)
+			if rw.Note != "" {
+				entry += ": " + rw.Note
+			}
+			failed = append(failed, entry)
 		}
 	}
 	if len(failed) > 0 {

submitqueue/client/view_test.go

@@ -504,6 +504,12 @@ func TestOutcome(t *testing.T) {
 func TestSummarize(t *testing.T) {
 	assert.NoError(t, summarize([]*Row{{SQID: "q/1", Status: "landed"}}))
 	assert.Error(t, summarize([]*Row{{SQID: "q/1", Status: "landed"}, {SQID: "q/2", Status: "error"}}))
+
+	// A failure reason, when the request carries one, is part of the summary so a
+	// scripted run reports why rather than only that.
+	err := summarize([]*Row{{SQID: "q/2", Status: "error", Note: "merge failed: conflict in foo.go"}})
+	require.Error(t, err)
+	assert.Contains(t, err.Error(), "q/2=error: merge failed: conflict in foo.go")
 }
 
 // TestRowLineAlignment is the column contract: on every row the stage begins at