Skip to content

Commit d7fb1cf

Browse files
committed
fix(demo): let demo-queue inherit the fake build runner
## Summary ### Why? `demo-queue` pinned the GitHub Actions build runner, so every land waited on a real CI run. That is not what the demo is for: it exists to show the queue batching, speculating and merging, and a walkthrough that spends most of its time watching a workflow spin says very little about any of that. The configuration had also drifted from its own documentation, which already describes the fake runner as the default and real CI as the thing you opt into. ### What? The queue no longer names a build runner, so it inherits `{type: fake}` from the defaults and every build succeeds instantly. A land now completes in seconds. The comment that offered the Actions block said to "replace the line above with the block below", which after this points at the change provider rather than at anything to do with builds. It now says to add the block, and explains what inheriting the default actually gets you. Real CI remains one uncommented block away, and the how-to still documents the three things it needs. ## Test Plan ✅ `make local-provider-start PROVIDER=github` parses the configuration on startup and refuses to start on an invalid one, so a malformed profile fails loudly rather than silently falling back. ✅ No code change: the fake runner is an existing implementation already used by every other queue in this file and by the local provider. # Conflicts: # service/submitqueue/demo/provider/github/profiles.yaml # Please enter the commit message for your changes. Lines starting # with '#' will be kept; you may remove them yourself if you want to. # An empty message aborts the commit. # # interactive rebase in progress; onto ff81ffb # Last commands done (4 commands done): # pick f431564 # feat(demo): open independent pull requests in parallel # pick 0746c18 # fix(demo): let demo-queue inherit the fake build runner # Next command to do (1 remaining command): # pick 06080b1 # fix(client): bound the list window at the call time # You are currently rebasing. # # Changes to be committed: # modified: service/submitqueue/demo/provider/github/profiles.yaml #
1 parent a0bd02e commit d7fb1cf

1 file changed

Lines changed: 6 additions & 12 deletions

File tree

service/submitqueue/demo/provider/github/profiles.yaml

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -25,19 +25,13 @@ queues:
2525
# detection.
2626
analyzer: {type: pathoverlap, by: directory}
2727

28-
# Every build succeeds instantly, so a land completes in seconds and the
29-
# demo exercises the merge rather than waiting on CI.
30-
buildRunner:
31-
type: githubactions
32-
owner: behinddwalls
33-
repo: sq-demo
34-
workflow: ci.yml # file name or numeric workflow id
35-
ref: main # the branch the workflow definition is read from
28+
# The build runner is inherited from the defaults above, so every build
29+
# succeeds instantly. A land then completes in seconds, and the demo shows
30+
# the queue and the merge rather than spending its time waiting on CI.
3631
#
37-
# To run real CI instead, replace the line above with the block below. It
38-
# needs a workflow in the target repository that is triggerable by
39-
# workflow_dispatch and accepts the sq_base_uris / sq_head_uris inputs, and
40-
# a token with the `workflow` scope.
32+
# To run real CI instead, add the block below. It needs a workflow in the
33+
# target repository that is triggerable by workflow_dispatch and accepts the
34+
# sq_base_uris / sq_head_uris inputs, and a token with the `workflow` scope.
4135
#
4236
# buildRunner:
4337
# type: githubactions

0 commit comments

Comments
 (0)