Skip to content

Commit dd197d9

Browse files
committed
fix(demo): let demo-queue inherit the fake build runner
## Summary ### Why? `demo-queue` pinned the GitHub Actions build runner, so every land waited on a real CI run. That is not what the demo is for: it exists to show the queue batching, speculating and merging, and a walkthrough that spends most of its time watching a workflow spin says very little about any of that. The configuration had also drifted from its own documentation, which already describes the fake runner as the default and real CI as the thing you opt into. ### What? The queue no longer names a build runner, so it inherits `{type: fake}` from the defaults and every build succeeds instantly. A land now completes in seconds. The comment that offered the Actions block said to "replace the line above with the block below", which after this points at the change provider rather than at anything to do with builds. It now says to add the block, and explains what inheriting the default actually gets you. Real CI remains one uncommented block away, and the how-to still documents the three things it needs. ## Test Plan ✅ `make local-provider-start PROVIDER=github` parses the configuration on startup and refuses to start on an invalid one, so a malformed profile fails loudly rather than silently falling back. ✅ No code change: the fake runner is an existing implementation already used by every other queue in this file and by the local provider.
1 parent 1426930 commit dd197d9

1 file changed

Lines changed: 6 additions & 13 deletions

File tree

service/submitqueue/demo/provider/github/profiles.yaml

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -17,20 +17,13 @@ queues:
1717
# Enterprise, add `github: {baseUrl: https://ghe.example.com/api/v3}`.
1818
changeProvider: {type: github}
1919

20-
21-
# Every build succeeds instantly, so a land completes in seconds and the
22-
# demo exercises the merge rather than waiting on CI.
23-
buildRunner:
24-
type: githubactions
25-
owner: behinddwalls
26-
repo: sq-demo
27-
workflow: ci.yml # file name or numeric workflow id
28-
ref: main # the branch the workflow definition is read from
20+
# The build runner is inherited from the defaults above, so every build
21+
# succeeds instantly. A land then completes in seconds, and the demo shows
22+
# the queue and the merge rather than spending its time waiting on CI.
2923
#
30-
# To run real CI instead, replace the line above with the block below. It
31-
# needs a workflow in the target repository that is triggerable by
32-
# workflow_dispatch and accepts the sq_base_uris / sq_head_uris inputs, and
33-
# a token with the `workflow` scope.
24+
# To run real CI instead, add the block below. It needs a workflow in the
25+
# target repository that is triggerable by workflow_dispatch and accepts the
26+
# sq_base_uris / sq_head_uris inputs, and a token with the `workflow` scope.
3427
#
3528
# buildRunner:
3629
# type: githubactions

0 commit comments

Comments
 (0)