Skip to content

Commit 014ef80

Browse files
authored
fix(gds): do not throw error on ports with missing labels (#595)
1 parent cc228d0 commit 014ef80

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

libs/gdsconv/src/conv.rs

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,11 @@ pub fn from_gds<L: FromGds + Hash + Eq + Clone>(
117117
}
118118
}
119119

120+
// If name is None, no label was found for this shape.
121+
// We ignore shapes with missing labels.
122+
// In the future, we can perform connectivity analysis
123+
// to identify other pins to which this shape is connected,
124+
// and then add this shape to the appropriate pin.
120125
if let Some(name) = name {
121126
if ocell.try_port(&name).is_none() {
122127
ocell.add_port(&name, Port::new(Direction::InOut));
@@ -129,10 +134,6 @@ pub fn from_gds<L: FromGds + Hash + Eq + Clone>(
129134
// behavior in the future.
130135
port.add_element(text);
131136
}
132-
} else {
133-
return Err(FromGdsError::PinWithNoLabel {
134-
cell: cell.name().clone(),
135-
});
136137
}
137138
}
138139
}

0 commit comments

Comments
 (0)