Few Problems related to INC2004642

[jSylvestre]

User was able to submit request without a PI or Access type.
I was able to do it without a PI on test with a create account.
This was for: Add Account To Group

But... Looking at the group for that account, it is {
"uid": 1359144,
"gid": 1359144,
"groups": [
"ecl243grp"
],
"shell": "/bin/bash",
"ensure": "present",
"storage": {
"zfs": false,
"autofs": {
"nas": "nas-12-3",
"path": "/nas-12-3/adamgrp/5/"
}
}
}

Account email starts with tburnha

And that group isn't in the DB

[sprucely]

Group ecl243grp doesn't have any sponsors, so it's not supposed to be synced to Hippo.

[sprucely]

• PI was a field requested by only one cluster. To avoid cluster-specific customization, we made that an optional input. Should we instead make it required for all clusters or add another cluster configuration option?
• As currently structured, it wouldn't make sense to have Access Type as an option when adding an account to another group. Access Type is account-specific in Hippo, not group-specific. Is that wrong?
• Another problem with Access Type is that it's not synced from Puppet, and I'm not sure if there is an obvious way to do that. Until that's possible the only thing we could do is pull AccessType from QueuedEvent once it is marked as completed, just like we do with SshKey. But that still leaves us with the problem of having no AccessType info for accounts that were created outside of Hippo.

[sprucely]

I haven't been able to reproduce the original problem. And PI is supposed to be optional.