From 4a1ef7b6d635c33001653968b3e67ed780591c5d Mon Sep 17 00:00:00 2001 From: "Anosh D. Ullenius" Date: Thu, 20 Jul 2023 15:35:00 +0200 Subject: [PATCH] Update changelog. Don't output minor version number --- changelog.md | 10 ++++++++++ src/main/java/se/anosh/spctag/TagReader.java | 4 ++-- src/main/java/se/anosh/spctag/dao/SpcFileReader.java | 2 -- 3 files changed, 12 insertions(+), 4 deletions(-) diff --git a/changelog.md b/changelog.md index 500fafa..3f2b936 100644 --- a/changelog.md +++ b/changelog.md @@ -1,5 +1,15 @@ # Changelog +## 2.3.1 +A warning is printed if the minor version (binary) field doesn't match the +minor version in the header (plain text). + +### Bug fix: +Mixing (pre-amp) level is parsed correctly (xid6). + +The length is 4 bytes. The old spec had an error where this field's length was +set to 1 byte. This was fixed in commit 29082c0e but the code was never updated. + ## v2.3.0 ### New features Add support for two ID666-fields: diff --git a/src/main/java/se/anosh/spctag/TagReader.java b/src/main/java/se/anosh/spctag/TagReader.java index a067c3b..ab41cd0 100644 --- a/src/main/java/se/anosh/spctag/TagReader.java +++ b/src/main/java/se/anosh/spctag/TagReader.java @@ -19,7 +19,7 @@ */ public final class TagReader { - private static final String VERSION ="spctag version 2.3.0"; + private static final String VERSION ="spctag version 2.3.1"; private static final String ABOUT = "code by A. Ullenius 2019-2023"; private static final String LICENCE = "Licence: Gnu General Public License - version 3.0 only"; private static final String TRIBUTE = "spctag is dedicated to my favourite OC remixer: Avien (1986-2004). RIP"; @@ -73,7 +73,7 @@ public void go(final CommandLine cmd) { System.out.println("File header: " + myFile.getHeader()); String format = myFile.isBinaryTagFormat() ? "Binary" : "Text"; System.out.println("Tag format: " + format); - System.out.printf("SPC version minor: %d\n", myFile.getVersion()); + //System.out.printf("SPC version minor: %d\n", myFile.getVersion()); } System.out.println("Artist: " + myFile.getArtist()); // composer System.out.println("Song title: " + myFile.getSongTitle()); diff --git a/src/main/java/se/anosh/spctag/dao/SpcFileReader.java b/src/main/java/se/anosh/spctag/dao/SpcFileReader.java index dbf6086..28b7ad4 100644 --- a/src/main/java/se/anosh/spctag/dao/SpcFileReader.java +++ b/src/main/java/se/anosh/spctag/dao/SpcFileReader.java @@ -54,11 +54,9 @@ private void readAndSetAllFields() throws IOException { if (id666.hasId666Tags()) { readSongTitle(); readGameTitle(); - readNameOfDumper(); readComments(); - readTagFormat(); // these depend on the tag-format being binary or text