Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ModalManager Context to allow a modal to be protected/peristant through Navigation Changes #18652

Open
warrenbuckley opened this issue Mar 12, 2025 · 1 comment

Comments

@warrenbuckley
Copy link
Contributor

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

15.x

Bug summary

Allow a modal to be opened from a Workspace context and prevent from opening and closing quickly.

Specifics

Context

https://forum.umbraco.com/t/opening-a-modal-from-workspace-context-when-content-node-loads-closes-itself-straight-away/771?u=warren

We needed a way to close modals when navigation happens, because they would otherwise stay open, and we did not want to make people also have to code that into their logic. What could work for you is if we added configuration to the modal context to protect a modal, i.e. mark it as indisposable or similar.

(Please create an issue on the tracker about this)

☝ Hence here is this issue...

Steps to reproduce

Use the code from the forum post above as an example of opening a modal from a workspace context.

Expected result / actual result

A modal can be opened and not be closed from a workspace context

@umbracocommunity
Copy link

This issue has been mentioned on Umbraco community forum. There might be relevant details there:

https://forum.umbraco.com/t/opening-a-modal-from-workspace-context-when-content-node-loads-closes-itself-straight-away/771/3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants