Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving document creates multiple copies when missing mandatory image is not provided #18664

Open
skcinton opened this issue Mar 12, 2025 · 4 comments
Labels
state/needs-reproduction Check if this can be reproduced in the latest released version type/bug

Comments

@skcinton
Copy link

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

13.7.1

Bug summary

The automatic upgrade to v13.7.1 this week appears to have caused a new bug with saving a document, when a mandatory image field is not filled, if you click save once or more (no alert, no visual border change or message to say the image field was not filled) and then add the missing image, following by saving, there are multiple copies of your page/document appearing in the navigation node list.
There is a copy for each time you click the save button before filling the image field.
They only show once you add the image and click save a final time.
Additionally, there is no visual alert for the image field not being filled in (the same as the mandatory block grid field).

Specifics

We've tested in Safari and Chrome, two different environments (both v13.7.1).
Umbraco Chat doesn't want to provide support for this issue even though it's caused by the automatic update.

Steps to reproduce

Using a document model that has a mandatory image field, create a document with that model.
Do not fill in the image field, click save or save and publish a few times.
Then add the image and click save or save and publish.
The navigation node list will show a copy of the document prior to the image being added and then a final version with the image added.

Expected result / actual result

It should not create multiple versions of the document, it should show the mandatory image field (or block grid field) as not being filled when you forget to fill it and click save.

Copy link

Hi there @skcinton!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@AndyButland
Copy link
Contributor

AndyButland commented Mar 13, 2025

Hi @skcinton - I've not been able to replicate this I'm afraid. Please see the following which is on a clean install of 13.7.1 on Cloud. Are you able to spot anything different in what I've done compared to what you are seeing please?

Screen.Recording.2025-03-13.065902.mp4

Just to note that it is normal for a save and publish that doesn't validate to still save, but not publish. So it's expected you get a single, unpublished node created after a save that fails validation. But on the successful save and publish, you should - and for me, do - see that originally created unpublished node updated, rather than an additional one created.

@AndyButland AndyButland added the state/needs-reproduction Check if this can be reproduced in the latest released version label Mar 13, 2025
@skcinton
Copy link
Author

Thanks @AndyButland

I've run this locally and in Umbraco Cloud now, I can say it works fine locally including the field validation messages.

However, in Umbraco Cloud (same version of the Umbraco application) it fails to work correctly.

Thank you,
Ryan

@AndyButland
Copy link
Contributor

OK, it's not expected that you should see different behaviour of course, assuming you are running the same versions.

This shouldn't be necessary - and I don't really see that it could relate to the patch release as they updates there were all server-side - but maybe it's just worth you making sure the backoffice assets are fully invalidated in the cache via this method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state/needs-reproduction Check if this can be reproduced in the latest released version type/bug
Projects
None yet
Development

No branches or pull requests

2 participants