feat: allow signup with promo codes (#888)

* feat: allow signup with promo codes

* feat: case insensitive promo code match

Author: nbiton

imports/api/hooks/on-create-user.js

@@ -5,14 +5,24 @@ import randToken from 'rand-token'
 import bugzillaApi from '../../util/bugzilla-api'
 import { baseUserSchema } from '../custom-users'
 import { logger } from '../../util/logger'
+import PromoCodes from '../promo-codes'
 
 // Exported for testing purposes
 export function onCreateUser (options, user) {
   const { callAPI } = bugzillaApi
-  const { bzLogin, bzPass } = options.profile
+  const { bzLogin, bzPass, promoCode } = options.profile
   delete options.profile.bzLogin
   delete options.profile.bzPass
 
+  if (promoCode) {
+    const promoCodeRecord = PromoCodes.findOne({ code: new RegExp(promoCode.toLowerCase(), 'i') })
+    if (!promoCodeRecord) {
+      throw new Meteor.Error('Promo code does not exist')
+    } else if (promoCodeRecord.expiresOn && promoCodeRecord.expiresOn.getTime() < Date.now()) {
+      throw new Meteor.Error('This promo code has expired')
+    }
+  }
+
   // Creating a random bz pass if one was not provided
   const password = bzPass || 'a' + randToken.generate(10) + '!'
   const { email } = options

imports/api/hooks/on-login-failure.js

@@ -2,6 +2,8 @@ import { Accounts } from 'meteor/accounts-base'
 import { logger } from '../../util/logger'
 
 Accounts.onLoginFailure(({ user, type, error }) => {
-  const userIdentifier = user.emails ? `User with email ${user.emails[0].address}` : `User ${user._id}`
-  logger.warn(`${userIdentifier} has tried to login with the '${type}' method unsuccessfully. Reason: "${error.reason}"`)
+  if (user) {
+    const userIdentifier = user.emails ? `User with email ${user.emails[0].address}` : `User ${user._id}`
+    logger.warn(`${userIdentifier} has tried to login with the '${type}' method unsuccessfully. Reason: "${error.reason}"`)
+  }
 })

imports/api/promo-codes.js

@@ -0,0 +1,12 @@
+import { Mongo } from 'meteor/mongo'
+
+export const collectionName = 'promoCodes'
+
+/* Contains docs of format:
+  {
+    code: string
+    createdAt: Date
+    expiresOn?: Date
+  }
+*/
+export default new Mongo.Collection(collectionName)

imports/ui/signup/signup.actions.js

@@ -10,10 +10,11 @@ type Action = {
   type: string
 }
 
- type Info = {
-    password: string,
-    emailAddress: string
-  }
+type Info = {
+  password: string,
+  emailAddress: string,
+  promoCode: ?string
+}
 
 type Dispatch = (action: Action) => any;
 type ThunkAction = (dispatch: Dispatch) => any
@@ -28,6 +29,7 @@ export function submitSignupInfo (info: Info): ThunkAction {
       email: info.emailAddress,
       password: info.password,
       profile: {
+        promoCode: info.promoCode
       }
     }, (err) => {
       if (err) {

imports/ui/signup/signup.jsx

@@ -25,7 +25,8 @@ type State = {
   termsAgreement: boolean,
   info: {
     password: string,
-    emailAddress: string
+    emailAddress: string,
+    promoCode: string
   },
   errorTexts: {}
 }
@@ -35,6 +36,7 @@ type Inputs = Array<{
   identifier: string,
   placeholder: string,
   type: string,
+  optional?: boolean,
   onChange: (evt: SyntheticInputEvent<HTMLInputElement>) => void
 }>
 
@@ -47,7 +49,8 @@ export class SignupPage extends React.Component<Props, State> {
       termsAgreement: false,
       info: {
         password: '',
-        emailAddress: ''
+        emailAddress: '',
+        promoCode: ''
       },
       errorTexts: {}
     }
@@ -68,6 +71,20 @@ export class SignupPage extends React.Component<Props, State> {
             })
           })
         }
+      },
+      {
+        label: 'Promo code',
+        identifier: 'promoCode',
+        optional: true,
+        placeholder: 'Signing up for a promo?',
+        type: 'text',
+        onChange: (evt) => {
+          const { value } = evt.target
+          const { info } = this.state
+          this.setState({
+            info: Object.assign({}, info, { promoCode: value })
+          })
+        }
       }
     ]
 
@@ -97,7 +114,7 @@ export class SignupPage extends React.Component<Props, State> {
   isFormValid = () => {
     const { info, errorTexts, termsAgreement } = this.state
     return (
-      this.inputs.filter(({ identifier }) => !!info[identifier]).length === this.inputs.length && // All have a value
+      this.inputs.filter(({ identifier, optional }) => optional || !!info[identifier]).length === this.inputs.length && // All have a value
       Object.keys(errorTexts).filter(key => !!errorTexts[key]).length === 0 && // No error messages
       !!info.password && // Password has a value
       !!termsAgreement
@@ -121,7 +138,13 @@ export class SignupPage extends React.Component<Props, State> {
               {this.inputs.map(({ label, identifier, placeholder, type, onChange }, i) => (
                 <InputRow key={i} label={label} placeholder={placeholder} inpType={type} value={info[identifier]}
                   onChange={evt => onChange ? onChange(evt) : this.makeInfoChange({ [identifier]: evt.target.value })}
-                  errorText={errorTexts[identifier] || userCreationState.error}
+                  errorText={
+                    errorTexts[identifier] || (
+                      userCreationState.error &&
+                      userCreationState.error.match(new RegExp(label.toLowerCase(), 'i')) &&
+                      userCreationState.error
+                    )
+                  }
                 />
               ))}
               {userCreationState.error && userCreationState.error.includes('Email') &&

server/main.js

@@ -15,6 +15,7 @@ import '../imports/api/notification-settings-overrides'
 import '../imports/api/failed-unit-creations'
 import '../imports/api/increment-counters'
 import '../imports/api/internal-api-payloads'
+import '../imports/api/promo-codes'
 import '../imports/api/hooks/on-create-user'
 import '../imports/api/hooks/on-login'
 import '../imports/api/hooks/on-login-failure'