You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
**Choose your PR title well:** Your pull request title is what's used to create release notes, so please make it descriptive of the change itself, which may be different from the initial motivation to make the change.
2
-
3
1
## Overview
4
2
5
-
What does this change accomplish and why?
6
-
i.e. How does it change the user experience?
7
-
i.e. What was the old behavior/API and what is the new behavior/API?
3
+
-\[\] What does this change accomplish and why?
4
+
5
+
- \[\] i.e. How does it change the user experience?
6
+
- \[\] i.e. What was the old behavior/API and what is the new behavior/API?
8
7
9
-
Feel free to include "before and after" examples if appropriate. (You can copy/paste screenshots directly into this editor.)
8
+
-\[\] Include "before and after" examples if appropriate. (You can copy/paste screenshots directly into this editor.)
10
9
11
-
If relevant, which Github issues does it close? (See [closing-issues-using-keywords](https://help.github.com/en/enterprise/2.16/user/github/managing-your-work-on-github/closing-issues-using-keywords).)
10
+
-\[\] List any Github issues that this PR closes, in [closing-issues-using-keywords](https://help.github.com/en/enterprise/2.16/user/github/managing-your-work-on-github/closing-issues-using-keywords) format.
12
11
13
-
## Implementation notes
12
+
## Implementation approach and notes
14
13
15
14
How does it accomplish it, in broad strokes? i.e. How does it change the Haskell codebase?
16
15
@@ -21,12 +20,18 @@ What could have been done differently, but wasn't? And why?
21
20
22
21
## Test coverage
23
22
24
-
Have you included tests (which could be a transcript) for this change, or is it somehow covered by existing tests?
23
+
-\[\]Have you included tests (which could be a transcript) for this change, or is it somehow covered by existing tests?
25
24
26
-
Would you recommend improving the test coverage (either as part of this PR or as a separate issue) or do you think it’s adequate?
25
+
-\[\]Would you recommend improving the test coverage (either as part of this PR or as a separate issue) or do you think it’s adequate?
27
26
28
-
If you only tested by hand, because that's all that's practical to do for this change, mention that.
27
+
-\[\]If you only tested by hand, because that's all that's practical to do for this change, mention that. Include screenshots.
29
28
30
29
## Loose ends
31
30
32
31
Link to related issues that address things you didn't get to. Stuff you encountered on the way and decided not to include in this PR.
32
+
33
+
## Final checklist
34
+
35
+
-\[\]**Choose your PR title well:** Your pull request title is what's used to create release notes, so please make it descriptive of the change itself, which may be different from the initial motivation to make the change.
36
+
-\[\]**Update your PR description** if the specifics of the PR have changed over time.
37
+
-\[\]**Include transcripts or screenshots** that demonstrate the changed behavior.
0 commit comments