Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle AppIcon per platform #117

Open
pictos opened this issue Apr 25, 2023 · 0 comments
Open

Handle AppIcon per platform #117

pictos opened this issue Apr 25, 2023 · 0 comments
Labels
kind/enhancement New feature or request. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done.

Comments

@pictos
Copy link
Contributor

pictos commented Apr 25, 2023

Right now for 4.9, we make sure that ForegroundScale will have a variation per platform but still uses the Skia code to re-scale the asset. We've an opportunity to make this even more platform-specific, handling that using whatever the platform exposes to us.

On Android, for example, we can do that inside the splash drawable xml file, using the android:inset attribute, so we can create this xml when user specifies the AnroidForegroundScale:

<?xml version="1.0" encoding="utf-8"?>
<adaptive-icon xmlns:android="http://schemas.android.com/apk/res/android">
  <background android:drawable="@color/ic_launcher_background"/>
  <foreground>
    <inset
      android:drawable="@drawable/ic_launcher_foreground"
      android:inset="16%" />
  </foreground>
</adaptive-icon>

And we can extend that for platforms that exposes ways to customize the app icon

@pictos pictos added kind/enhancement New feature or request. triage/untriaged Indicates an issue requires triaging or verification. labels Apr 25, 2023
@nickrandolph nickrandolph added priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. and removed triage/untriaged Indicates an issue requires triaging or verification. labels Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done.
Projects
None yet
Development

No branches or pull requests

2 participants