Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splash screen PNG files are not generated when UnoIcon and UnoSplashScreen are the same file. #98

Open
4 of 11 tasks
ADD-David-Antolin opened this issue Mar 23, 2023 · 3 comments
Assignees
Labels
kind/enhancement New feature or request. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done.

Comments

@ADD-David-Antolin
Copy link

Current behavior

Splash screen PNG files are not being generated in all heads when UnoSplashScreen Include attribute is the same SVG file as UnoIcon but with a Link attribute. This has different behaviors on each head:

  • WinUI. PNG files are generated and the splash screen is shown.
  • Android. PNG files are not generated and provoke compiler errors APT2062 failed linking references and APT2260 resource drawable/splash_screen not found.
  • iOS. Although the PNG files are not generated the splash screen image is shown.
  • WebAssembly. PNG files are not generated and alternate text is shown instead of the splash screen image.
  • Skia.WPF. PNG files are not generated and the splash screen image is not shown.

Expected behavior

I think it should generate the PNG files in all heads based on the filename that is in the Link attribute. It is not uncommon that the splash screen is the same vector file as the application icon.

At minimum, a validation error or warning provided by uno.resizetizer saying that doing that is not supported (the same way it signals when the is more than on UnoSplashScreen item).

How to reproduce it (as minimally and precisely as possible)

  1. Create a new Uno Platform app with the Visual Studio Extension.
  2. Close Visual Studio.
  3. Go to Base folder.
  4. Remove iconapp.svg and rename appconfig.svg to iconapp.svg
  5. Go to base.props and modify UnoSplashScreen so the Include attribute is the same as UnoIcon. Also add Link="splash_screen.svg" to UnoSplashScreen and remove ForegroundFile of UnoIcon.
  6. Ensure bin and obj folders of all heads are deleted and delete them manually if not.
  7. Open the solution.
  8. Compile all heads.

Environment

Nuget Package:

Package Version(s): 1.0.2

Affected platform(s):

  • iOS
  • Android
  • WebAssembly
  • WebAssembly renders for Xamarin.Forms
  • Skia
  • Windows
  • Build tasks

Visual Studio:

  • 2017 (version: )
  • 2019 (version: )
  • 2022 (version: 17.5.2)
  • for Mac (version: )
@ADD-David-Antolin ADD-David-Antolin added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification. labels Mar 23, 2023
@jeromelaban jeromelaban removed the triage/untriaged Indicates an issue requires triaging or verification. label Mar 23, 2023
@Youssef1313
Copy link
Member

For Android, maybe unoplatform/uno#11860 fixes it. Not sure, and haven't looked into the other platforms.

@pictos pictos added kind/enhancement New feature or request. and removed kind/bug Something isn't working labels Apr 11, 2023
@pictos
Copy link
Contributor

pictos commented Apr 11, 2023

Changed it to be an enhancement because this is by design. The winUI works because it handles the assets, putting everything in the same place, whereas other platform handles it in a different way. That can be doable but will not be easy to do in one go, so I would like to have more feedback from our users before committing to implementing this.

@jeromelaban
Copy link
Member

Could we provide an error message to mention that this is not a supported scenario?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done.
Projects
None yet
Development

No branches or pull requests

5 participants