Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

single shims function calls move_to and Getattr #447

Closed
mmckerns opened this issue Jan 27, 2022 · 5 comments · Fixed by #473
Closed

single shims function calls move_to and Getattr #447

mmckerns opened this issue Jan 27, 2022 · 5 comments · Fixed by #473
Labels
Milestone

Comments

@mmckerns
Copy link
Member

The @move_to decorator must be paired with the overloading by the Getattr later in the shims module. It seems like with a little redesign, this could be consolidated to a single function / decorator.

@mmckerns mmckerns changed the title refactor so single shims function/decorator calls move_to and Getattr single shims function/decorator calls move_to and Getattr Jan 27, 2022
@mmckerns mmckerns changed the title single shims function/decorator calls move_to and Getattr single shims function calls move_to and Getattr Jan 27, 2022
@mmckerns
Copy link
Member Author

mmckerns commented Jan 27, 2022

See #443 for reference. Tag: @anivegesana

@anivegesana
Copy link
Contributor

This construct tries to give a base definition for a function that will be or was defined differently in another version of Python or dill. Because of this, should we just call both move_to and Getattr put together soft_def?

@mmckerns
Copy link
Member Author

mmckerns commented May 9, 2022

I was thinking about something along those lines, yes.

@anivegesana
Copy link
Contributor

Do you do think there is any value in having a separate Getattr and move_to function along with a soft_def function? I guess we could add them back in if they are found to be useful for something else.

@mmckerns
Copy link
Member Author

mmckerns commented May 9, 2022

It doesn't hurt to keep them available as separate functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants