Skip to content

Switch to noxfile.py or toxfile.py #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fayazkhan opened this issue May 17, 2025 · 1 comment · Fixed by #97
Closed

Switch to noxfile.py or toxfile.py #96

fayazkhan opened this issue May 17, 2025 · 1 comment · Fixed by #97

Comments

@fayazkhan
Copy link
Collaborator

Problem

The current configuration of SQLA versions to be tested is statically defined in tox.ini.
This doesn't cause any major code duplication or technical debt as the only other place this is constrained is in the requirements.txt.

However, this prevents @dependabot from functioning properly as it is not aware of the definitions in tox.ini. See #94.

Solution

To enable smooth functioning of @dependabot and also reduce code duplication, we should switch to a dynamic method of generating test environments.

nox seems to support this workflow. There also seems to be support added to newer versions of tox to achieve this using a toxfile.py similar to a noxfile.py from nox.

@fayazkhan
Copy link
Collaborator Author

Currently nox[uv] seems to be unable to work with pypy3.7:

nox > Running session test-pypy-3.7(sqlalchemy=0)
error: No download found for request: pypy-3.7-linux-x86_64-gnu
nox > Missing interpreters will error by default on CI systems.
nox > Session test-pypy-3.7(sqlalchemy=0) skipped: Python interpreter pypy3.7 not found.

So, maybe this switch would be less harmful when we drop support for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant