Merge pull request #2983 from uw-it-aca/qa

Qa

Author: fanglinfang

myuw/management/commands/db_cleanup.py

@@ -71,7 +71,7 @@ def course_display(self):
         # clean up after one year
         timer = Timer()
         queryf = "DELETE FROM user_course_display_pref WHERE id IN ({})"
-        term = get_term_by_date(sws_now())
+        term = get_term_by_date(sws_now().date())
         y = term.year - 1
         q = term.quarter
         qset = UserCourseDisplay.objects.filter(year=y, quarter=q)
@@ -103,7 +103,7 @@ def registration_seen(self):
         # clean up previous quarters'
         timer = Timer()
         queryf = "DELETE FROM myuw_mobile_seenregistration WHERE id IN ({})"
-        term = get_term_before(get_term_by_date(sws_now()))
+        term = get_term_before(get_term_by_date(sws_now().date()))
         qset = SeenRegistration.objects.filter(
             year=term.year, quarter=term.quarter)
         if qset.exists():

myuw/test/management/commands/test_db_cleanup.py

@@ -3,12 +3,16 @@
 
 from django.test import TestCase
 from django.core.management import call_command
+from unittest.mock import patch
+from uw_sws.term import get_specific_term
 
 
 class TestCheckResLinks(TestCase):
 
-    def test_run(self):
-        # call_command('db_cleanup', "course")
-        # call_command('db_cleanup', "seenreg")
+    @patch('myuw.dao.term.get_term_by_date', spec=True)
+    def test_run(self, mock):
+        mock.return_value = get_specific_term(2014, 'spring')
+        call_command('db_cleanup', "course")
+        call_command('db_cleanup', "seenreg")
         call_command('db_cleanup', "notice")
         call_command('db_cleanup', "linkvisit")