removed console log and added linter rule (#458)

* removed console log and added linter rule

* removed unnecessary logger info

Author: mcpenguin

.eslintrc

@@ -9,6 +9,7 @@
   "rules": {
     "@typescript-eslint/no-unused-vars": ["warn", { "argsIgnorePattern": "^_" }],
     "@typescript-eslint/no-non-null-assertion": "off",
+    "no-console": 1,
     "prettier/prettier": [
       "error",
       {

src/codeyCommand.ts

@@ -103,7 +103,6 @@ const setCommandOption = (
     T extends ApplicationCommandOptionBase &
       ApplicationCommandOptionWithChoicesAndAutocompleteMixin<B>,
   >(commandOption: T): T {
-    logger.info(option.choices);
     return option.choices
       ? commandOption.addChoices(...(option.choices as APIApplicationCommandOptionChoice<B>[]))
       : commandOption;

src/commandDetails/company/add.ts

@@ -17,7 +17,6 @@ const companyAddExecuteCommand: SapphireMessageExecuteType = async (
   if (!company_id) {
     throw new Error('please enter a valid crunchbase company id.');
   }
-  console.log(args);
   const role = args['role'];
   if (!role) {
     throw new Error('please enter your role at this company.');

src/commandDetails/company/find.ts

@@ -57,8 +57,6 @@ const companyFindExecuteCommand: SapphireMessageExecuteType = async (
     throw new Error('This company does not exist in the server!');
   }
   const companyUsers = await getEmployeesByCompanyId(<string>company_id);
-  console.log('here');
-  console.log(companyUsers);
   if (!companyUsers.length) {
     return 'No one works at this company in the server!';
   }

src/commandDetails/company/profile.ts

@@ -14,7 +14,6 @@ const companyProfileExecuteCommand: SapphireMessageExecuteType = async (
   const user = getUserFromMessage(messageFromUser);
   const companies = await getCompaniesByUserId(user.id);
   // return a string where each line is the company_id - company_name
-  console.log(companies);
   const companyString = companies.map((company) => `${company.name} - ${company.role}`).join('\n');
   return `You are associated with the following companies:\n${companyString}`;
 };

src/components/cron.ts

@@ -17,6 +17,7 @@ import {
 } from './suggestion';
 import { updateMemberRole, getRoleName, loadRoleMembers } from '../utils/roles';
 import { CodeyUserError } from '../codeyUserError';
+import { logger } from '../logger/default';
 
 const NOTIF_CHANNEL_ID: string = vars.NOTIF_CHANNEL_ID;
 const OFFICE_STATUS_CHANNEL_ID: string = vars.OFFICE_STATUS_CHANNEL_ID;
@@ -59,7 +60,7 @@ export const createOfficeStatusCron = (client: Client): CronJob =>
       await (messageChannel as TextChannel).setName(curName);
       const time = Math.floor(response['time']);
       const topic = `Last updated at <t:${time}:F> for you (<t:${time}:R>)`;
-      await (messageChannel as TextChannel).setTopic(topic).catch(console.error);
+      await (messageChannel as TextChannel).setTopic(topic).catch(logger.error);
     } else {
       throw 'Bad channel type';
     }