From 1055aa6db0fd784b7eddf76351742a9f715264d1 Mon Sep 17 00:00:00 2001 From: Marco Collovati Date: Fri, 23 Jan 2026 07:29:51 +0100 Subject: [PATCH 1/2] fix: fix compilation errors --- .../kotlin/com/vaadin/testbench/unit/internal/BasicUtils.kt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/vaadin-testbench-unit-shared/src/main/kotlin/com/vaadin/testbench/unit/internal/BasicUtils.kt b/vaadin-testbench-unit-shared/src/main/kotlin/com/vaadin/testbench/unit/internal/BasicUtils.kt index 12e7444a7..4ddee2018 100644 --- a/vaadin-testbench-unit-shared/src/main/kotlin/com/vaadin/testbench/unit/internal/BasicUtils.kt +++ b/vaadin-testbench-unit-shared/src/main/kotlin/com/vaadin/testbench/unit/internal/BasicUtils.kt @@ -140,7 +140,7 @@ fun Component.matches(spec: SearchSpec.() -> Unit): Boolean = */ fun T._focus() where T : Focusable<*>, T : Component { checkEditableByUser() - _fireEvent(FocusNotifier.FocusEvent(this, true)) + _fireEvent(FocusNotifier.FocusEvent(this, true, null)) } /** @@ -148,7 +148,7 @@ fun T._focus() where T : Focusable<*>, T : Component { */ fun T._blur() where T : Focusable<*>, T : Component { checkEditableByUser() - _fireEvent(BlurNotifier.BlurEvent(this, true)) + _fireEvent(BlurNotifier.BlurEvent(this, true, null)) } /** From f9d75f59b2d2ceb864a36bb02df37b80674d1752 Mon Sep 17 00:00:00 2001 From: Marco Collovati Date: Fri, 23 Jan 2026 08:01:01 +0100 Subject: [PATCH 2/2] fixes for compatibility with Vaadin 25.1 Button in 25.1 has a Text child --- .../unit/internal/DepthFirstTreeIteratorTest.kt | 9 ++++++++- .../com/vaadin/testbench/unit/internal/LocatorTest.kt | 5 ++++- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/vaadin-testbench-unit/src/test/kotlin/com/vaadin/testbench/unit/internal/DepthFirstTreeIteratorTest.kt b/vaadin-testbench-unit/src/test/kotlin/com/vaadin/testbench/unit/internal/DepthFirstTreeIteratorTest.kt index 6cb805574..e27e6d244 100644 --- a/vaadin-testbench-unit/src/test/kotlin/com/vaadin/testbench/unit/internal/DepthFirstTreeIteratorTest.kt +++ b/vaadin-testbench-unit/src/test/kotlin/com/vaadin/testbench/unit/internal/DepthFirstTreeIteratorTest.kt @@ -17,6 +17,7 @@ import com.vaadin.flow.component.orderedlayout.HorizontalLayout import com.vaadin.flow.component.orderedlayout.VerticalLayout import com.github.mvysny.dynatest.DynaNodeGroup import com.github.mvysny.dynatest.expectList +import com.vaadin.flow.component.Text fun DynaNodeGroup.depthFirstTreeIteratorTests() { test("DepthFirstTreeIterator") { @@ -28,7 +29,13 @@ fun DynaNodeGroup.depthFirstTreeIteratorTests() { val expected = mutableListOf() val root = VerticalLayout().apply { expected.add(this) - add(Button("Foo").apply { expected.add(this) }) + add(Button("Foo").apply { + expected.add(this) + // In Vaadin 25.1, Button also has a text node + this.children.filter { it is Text } + .findFirst() + .ifPresent { expected.add(it) } + }) add(HorizontalLayout().apply { expected.add(this) add(Span().apply { expected.add(this) }) diff --git a/vaadin-testbench-unit/src/test/kotlin/com/vaadin/testbench/unit/internal/LocatorTest.kt b/vaadin-testbench-unit/src/test/kotlin/com/vaadin/testbench/unit/internal/LocatorTest.kt index 185092ee5..a27fb65e1 100644 --- a/vaadin-testbench-unit/src/test/kotlin/com/vaadin/testbench/unit/internal/LocatorTest.kt +++ b/vaadin-testbench-unit/src/test/kotlin/com/vaadin/testbench/unit/internal/LocatorTest.kt @@ -199,7 +199,10 @@ internal fun DynaNodeGroup.locatorTest() { _get