From a7bddfd21c3fb91ce10051d0b421329f70b1691e Mon Sep 17 00:00:00 2001 From: Marco Collovati Date: Fri, 23 Jan 2026 14:44:17 +0100 Subject: [PATCH] test: fix JUnit 5 unit test module tests --- .../unit/internal/DepthFirstTreeIteratorTest.kt | 9 ++++++++- .../com/vaadin/testbench/unit/internal/LocatorTest.kt | 5 ++++- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/vaadin-testbench-unit-junit5/src/test/kotlin/com/vaadin/testbench/unit/internal/DepthFirstTreeIteratorTest.kt b/vaadin-testbench-unit-junit5/src/test/kotlin/com/vaadin/testbench/unit/internal/DepthFirstTreeIteratorTest.kt index 6cb805574..e27e6d244 100644 --- a/vaadin-testbench-unit-junit5/src/test/kotlin/com/vaadin/testbench/unit/internal/DepthFirstTreeIteratorTest.kt +++ b/vaadin-testbench-unit-junit5/src/test/kotlin/com/vaadin/testbench/unit/internal/DepthFirstTreeIteratorTest.kt @@ -17,6 +17,7 @@ import com.vaadin.flow.component.orderedlayout.HorizontalLayout import com.vaadin.flow.component.orderedlayout.VerticalLayout import com.github.mvysny.dynatest.DynaNodeGroup import com.github.mvysny.dynatest.expectList +import com.vaadin.flow.component.Text fun DynaNodeGroup.depthFirstTreeIteratorTests() { test("DepthFirstTreeIterator") { @@ -28,7 +29,13 @@ fun DynaNodeGroup.depthFirstTreeIteratorTests() { val expected = mutableListOf() val root = VerticalLayout().apply { expected.add(this) - add(Button("Foo").apply { expected.add(this) }) + add(Button("Foo").apply { + expected.add(this) + // In Vaadin 25.1, Button also has a text node + this.children.filter { it is Text } + .findFirst() + .ifPresent { expected.add(it) } + }) add(HorizontalLayout().apply { expected.add(this) add(Span().apply { expected.add(this) }) diff --git a/vaadin-testbench-unit-junit5/src/test/kotlin/com/vaadin/testbench/unit/internal/LocatorTest.kt b/vaadin-testbench-unit-junit5/src/test/kotlin/com/vaadin/testbench/unit/internal/LocatorTest.kt index 185092ee5..a27fb65e1 100644 --- a/vaadin-testbench-unit-junit5/src/test/kotlin/com/vaadin/testbench/unit/internal/LocatorTest.kt +++ b/vaadin-testbench-unit-junit5/src/test/kotlin/com/vaadin/testbench/unit/internal/LocatorTest.kt @@ -199,7 +199,10 @@ internal fun DynaNodeGroup.locatorTest() { _get