Revisiting errors emitted by StakeMath
#130
Comments
0x-r4bbit
added a commit
that referenced
this issue
Feb 20, 2025
ones There are a bunch of error codes that are either similar to other ones or not used at all. This commit moves them to the interface and removes the ones that aren't used anymore. Part of the reason we have so many unused errors becuase they had been "reintroduced" in `StakeMath`, which we'll revisit as well as described in #130
3 tasks
0x-r4bbit
added a commit
that referenced
this issue
Feb 20, 2025
ones There are a bunch of error codes that are either similar to other ones or not used at all. This commit moves them to the interface and removes the ones that aren't used anymore. Part of the reason we have so many unused errors becuase they had been "reintroduced" in `StakeMath`, which we'll revisit as well as described in #130
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Basically opening this discussion again: https://github.com/vacp2p/staking-reward-streamer/pull/109/files#r1914773210
StakeMathcurrently throws errors.This is generally not a bad thing but somewhat unexpected because it's just a library.
One case that strengthens this argument is that the code looks like there's missing checks in the staking manager.
Best example is here: #126
I've sent a PR to fix this, thought there was no such expected error, however it then turned out that the underlying
StakeMathlibrary catches this case and reverts accordingly. Here's the PR: #129As a result of this @gravityblast mentioned that these errors should not come from the library (which aligns with my initial feeling).
So we agreed on revisiting this.
The text was updated successfully, but these errors were encountered: