fix: clean up ansible errors

Signed-off-by: Chris Butler <chris.butler@redhat.com>

Author: butler54

.ansible-lint

@@ -1,14 +1,15 @@
 # Vim filetype=yaml
 ---
 offline: false
-requirements: requirements.yml
 
 exclude_paths:
-- .cache/
-- .github/
-- charts/
-- common/
-- tests/
+  - .cache/
+  - .github/
+  - charts/
+  - common/
+  - tests/
+  - requirements.yml
+  - values-*
 
 # warn_list:
 #   - yaml

.releaserc.yaml

@@ -1,7 +1,7 @@
 branches:
-- main
+  - main
 plugins:
-- "@semantic-release/commit-analyzer"
-- "@semantic-release/release-notes-generator"
-- "@semantic-release/github"
-- "@semantic-release/git"
+  - "@semantic-release/commit-analyzer"
+  - "@semantic-release/release-notes-generator"
+  - "@semantic-release/github"
+  - "@semantic-release/git"

ansible/azure-nat-gateway.yaml

@@ -18,7 +18,7 @@
       retries: 20
       delay: 5
 
-    - name: Get Azure credentials
+    - name: Get Azure configuration
       kubernetes.core.k8s_info:
         kind: ConfigMap
         namespace: openshift-cloud-controller-manager
@@ -41,7 +41,7 @@
       no_log: true
 
     - name: Create Public IP for NAT Gateway
-      azure_rm_publicipaddress:
+      azure.azcollection.azure_rm_publicipaddress:
         subscription_id: "{{ azure_subscription_id }}"
         tenant: "{{ azure_tenant_id }}"
         client_id: "{{ azure_client_id }}"
@@ -52,7 +52,7 @@
         allocation_method: "static"
 
     - name: Retrieve Public IP for NAT Gateway
-      azure_rm_publicipaddress_info:
+      azure.azcollection.azure_rm_publicipaddress_info:
         subscription_id: "{{ azure_subscription_id }}"
         tenant: "{{ azure_tenant_id }}"
         client_id: "{{ azure_client_id }}"
@@ -86,4 +86,3 @@
         name: "{{ azure_subnet }}"
         virtual_network_name: "{{ azure_vnet }}"
         nat_gateway: "{{ coco_nat_gateway_name }}"
-...

ansible/configure-issuer.yaml

@@ -7,44 +7,43 @@
   vars:
     kubeconfig: "{{ lookup('env', 'KUBECONFIG') }}"
   tasks:
-  - name: Get Azure credentials
-    kubernetes.core.k8s_info:
-      kind: Secret
-      namespace: openshift-cloud-controller-manager
-      name: azure-cloud-credentials
-    register: azure_credentials
-    retries: 20
-    delay: 5
-  - name: List DNS zones
-    azure.azcollection.azure_rm_dnszone_info:
-      #resource_group: "{{ azure_credentials['data']['re'] }}" # don't pass if 
-      auth_source: "auto"
-      subscription_id: "{{ azure_credentials.resources[0]['data']['azure_subscription_id'] | b64decode }}"
-      client_id: "{{ azure_credentials.resources[0]['data']['azure_client_id'] | b64decode }}"
-      secret: "{{ azure_credentials.resources[0]['data']['azure_client_secret'] | b64decode }}"
-      tenant: "{{ azure_credentials.resources[0]['data']['azure_tenant_id'] | b64decode }}"
-    register: dns_zones
-  # FIXME: This assumes only one dns zone is present. we should be matching against available dns zones.
-  - name: Split the Path
-    set_fact:
-      path_parts: "{{ dns_zones.ansible_info.azure_dnszones[0].id.split('/') }}"
-  - name: Find the Resource Group Name
-    set_fact:
-      resource_group: "{{ path_parts[4] }}"
-  - name: Get hosted zone
-    set_fact:
-      hosted_zone: "{{ dns_zones.ansible_info.azure_dnszones[0].name }}"
-  - name: "Set k8s cm"
-    kubernetes.core.k8s:
-      api_version: v1
-      kind: ConfigMap
-      resource_definition:
-        apiVersion: v1
+    - name: Get Azure credentials
+      kubernetes.core.k8s_info:
+        kind: Secret
+        namespace: openshift-cloud-controller-manager
+        name: azure-cloud-credentials
+      register: azure_credentials
+      retries: 20
+      delay: 5
+    - name: List DNS zones
+      azure.azcollection.azure_rm_dnszone_info:
+        auth_source: "auto"
+        subscription_id: "{{ azure_credentials.resources[0]['data']['azure_subscription_id'] | b64decode }}"
+        client_id: "{{ azure_credentials.resources[0]['data']['azure_client_id'] | b64decode }}"
+        secret: "{{ azure_credentials.resources[0]['data']['azure_client_secret'] | b64decode }}"
+        tenant: "{{ azure_credentials.resources[0]['data']['azure_tenant_id'] | b64decode }}"
+      register: dns_zones
+    # FIXME: This assumes only one dns zone is present. we should be matching against available dns zones.
+    - name: Split the Path
+      ansible.builtin.set_fact:
+        path_parts: "{{ dns_zones.ansible_info.azure_dnszones[0].id.split('/') }}"
+    - name: Find the Resource Group Name
+      ansible.builtin.set_fact:
+        resource_group: "{{ path_parts[4] }}"
+    - name: Get hosted zone
+      ansible.builtin.set_fact:
+        hosted_zone: "{{ dns_zones.ansible_info.azure_dnszones[0].name }}"
+    - name: "Set k8s cm"
+      kubernetes.core.k8s:
+        api_version: v1
         kind: ConfigMap
-        metadata:
-          name: dnsinfo
-          namespace: imperative
-        data:
-          resource_group: "{{ resource_group }}"
-          hosted_zone: "{{ hosted_zone }}"
-      state: present
+        resource_definition:
+          apiVersion: v1
+          kind: ConfigMap
+          metadata:
+            name: dnsinfo
+            namespace: imperative
+          data:
+            resource_group: "{{ resource_group }}"
+            hosted_zone: "{{ hosted_zone }}"
+        state: present

ansible/install-deps.yaml

@@ -4,9 +4,11 @@
   hosts: localhost
   gather_facts: false
   tasks:
-  - name: Install required collection
-    ansible.builtin.command:
-      cmd: ansible-galaxy collection install azure.azcollection
-  - name: Install a Python package
-    ansible.builtin.command:
-      cmd: pip install --user -r ~/.ansible/collections/ansible_collections/azure/azcollection/requirements.txt
+    - name: Ensure collection is installed
+      community.general.ansible_galaxy_install:
+        type: collection
+        name: azure.azcollection
+    - name: Install a Python package
+      ansible.builtin.pip:
+        requirements: "~/.ansible/collections/ansible_collections/azure/azcollection/requirements.txt"
+        extra_args: --user

requirements.yml

@@ -1,2 +1,2 @@
 collections:
-- azure.azcollection
+  - azure.azcollection