Cleanup, remove unnecessary methods

Signed-off-by: currantw <[email protected]>

Author: currantw

sources/Valkey.Glide/ConnectionConfiguration.cs

@@ -522,21 +522,6 @@ public T WithAuthentication(string username, IamAuthConfig iamConfig)
         {
             return WithCredentials(new ServerCredentials(username, iamConfig));
         }
-
-        /// <summary>
-        /// Configure server credentials for IAM authentication.
-        /// </summary>
-        /// <param name="username">The username for authentication.</param>
-        /// <param name="clusterName">The name of the ElastiCache or MemoryDB cluster.</param>
-        /// <param name="serviceType">The AWS service type (ElastiCache or MemoryDB).</param>
-        /// <param name="region">The AWS region where the cluster is located.</param>
-        /// <param name="refreshIntervalSeconds">Optional refresh interval in seconds.</param>
-        /// <returns>The builder instance for method chaining.</returns>
-        public T WithAuthentication(string username, string clusterName, ServiceType serviceType, string region, uint? refreshIntervalSeconds = null)
-        {
-            var iamConfig = new IamAuthConfig(clusterName, serviceType, region, refreshIntervalSeconds);
-            return WithCredentials(new ServerCredentials(username, iamConfig));
-        }
         #endregion
         #region Protocol
         /// <summary>

tests/Valkey.Glide.UnitTests/ConnectionConfigurationTests.cs

@@ -72,35 +72,13 @@ public void WithAuthentication_UsernameIamAuthConfig_ConfiguresCorrectly()
         Assert.Throws<ArgumentNullException>(() => builder.WithAuthentication(Username, (IamAuthConfig)null!));
     }
 
-    [Fact]
-    public void WithAuthentication_UsernameClusterServiceRegionRefreshInterval()
-    {
-        var builder = new StandaloneClientConfigurationBuilder();
-        builder.WithAuthentication(Username, ClusterName, ServiceType.MemoryDB, Region, RefreshIntervalSeconds);
-
-        var config = builder.Build();
-        var authenticationInfo = config!.Request.AuthenticationInfo!.Value;
-        var iamCredentials = authenticationInfo.IamCredentials!.Value;
-
-        Assert.Equal(Username, authenticationInfo.Username);
-        Assert.Null(authenticationInfo.Password);
-        Assert.Equal(ClusterName, iamCredentials.ClusterName);
-        Assert.Equal(Region, iamCredentials.Region);
-        Assert.Equal(FFI.ServiceType.MemoryDB, iamCredentials.ServiceType);
-        Assert.Equal(RefreshIntervalSeconds, iamCredentials.RefreshIntervalSeconds);
-
-        // Username, cluster name, and region cannot be null.
-        Assert.Throws<ArgumentNullException>(() => builder.WithAuthentication(null!, ClusterName, ServiceType.ElastiCache, Region, RefreshIntervalSeconds));
-        Assert.Throws<ArgumentNullException>(() => builder.WithAuthentication(Username, null!, ServiceType.ElastiCache, Region, RefreshIntervalSeconds));
-        Assert.Throws<ArgumentNullException>(() => builder.WithAuthentication(Username, ClusterName, ServiceType.ElastiCache, null!, RefreshIntervalSeconds));
-    }
-
     [Fact]
     public void WithAuthentication_MultipleCalls_LastWins()
     {
         // Password-based authentication last.
         var builder = new StandaloneClientConfigurationBuilder();
-        builder.WithAuthentication(Username, ClusterName, ServiceType.MemoryDB, Region);
+        var iamConfig = new IamAuthConfig(ClusterName, ServiceType.ElastiCache, Region, RefreshIntervalSeconds);
+        builder.WithAuthentication(Username, iamConfig);
         builder.WithAuthentication(Username, Password);
 
         var config = builder.Build();
@@ -113,7 +91,7 @@ public void WithAuthentication_MultipleCalls_LastWins()
         // IAM authentication last.
         builder = new StandaloneClientConfigurationBuilder();
         builder.WithAuthentication(Username, Password);
-        builder.WithAuthentication(Username, ClusterName, ServiceType.MemoryDB, Region, RefreshIntervalSeconds);
+        builder.WithAuthentication(Username, iamConfig);
 
         config = builder.Build();
         authenticationInfo = config!.Request.AuthenticationInfo!.Value;

tests/Valkey.Glide.UnitTests/ServerCredentialsTests.cs

@@ -61,10 +61,13 @@ public void ServerCredentials_UsernameIamAuthConfigWithCustomRefresh()
     [Fact]
     public void ServerCredentials_ThrowsArgumentNullException()
     {
+        // Password-based authentication.
         Assert.Throws<ArgumentNullException>(() => new ServerCredentials(null!));
         Assert.Throws<ArgumentNullException>(() => new ServerCredentials(Username, (string)null!));
 
+        // IAM authentication.
         var iamConfig = new IamAuthConfig(ClusterName, ServiceType.ElastiCache, Region);
         Assert.Throws<ArgumentNullException>(() => new ServerCredentials(null!, iamConfig));
+        Assert.Throws<ArgumentNullException>(() => new ServerCredentials(Username, (IamAuthConfig)null!));
     }
 }