Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform EVD outside relmatLmer/relmatGlmer #6

Open
variani opened this issue Mar 8, 2018 · 5 comments
Open

Perform EVD outside relmatLmer/relmatGlmer #6

variani opened this issue Mar 8, 2018 · 5 comments

Comments

@variani
Copy link
Owner

variani commented Mar 8, 2018

In the current version 0.1.10, the relationship matrix is passed to relmatLmer and then it is decomposed by Cholesky/EVD. The decomposition operation is not visible to the user and there is little control over, e.g. errors. See also issue #1.

library(lme4qtl)
data(dat40)

mod <- relmatLmer(trait1 ~ 1 + (1|ID), dat40, relmat = list(ID = kin2))

It would be helpful to have something like this:

evd_kin2 <- eigen(kin2)

mod <- relmatLmer(trait1 ~ 1 + (1|ID), dat40, relmat = list(ID = evd_kin2))
@variani variani changed the title Allow to perform EVD outside relmatLmer/relmatGlmer Perform EVD outside relmatLmer/relmatGlmer Mar 8, 2018
@jfranco1951
Copy link

Dear Variani, Thanks for the lme4qtl, it is working well. I did try the EVD enhancement in a parallel long process but got an error message, then did try with the dat40 example and got the same message:

packageVersion("lme4qtl")
[1] ‘0.2.2’
evd_kin2 <- eigen(kin2)
mod <- relmatLmer(trait1 ~ 1 + (1|ID), dat40, relmat = list(ID = evd_kin2))
Error in relmat_lmer(trait1 ~ 1 + (1 | ID), dat40, relmat = list(ID = evd_kin2)) :
!is.null(rownames(relmat[[fn]])) is not TRUE

Thanks for help, J Franco

@variani
Copy link
Owner Author

variani commented Jun 14, 2021

Hi J Franco,

This issue is flagged as enhancement, meaning that I wish to implement this feature in the future. Though, I was not able to fine time for it, as you can see from the date the issue was created.

Currently, relmat argument supports only matrices with rownames to be IDs.

Best,
Andrey

@jfranco1951
Copy link

jfranco1951 commented Jun 15, 2021 via email

@variani
Copy link
Owner Author

variani commented Jun 17, 2021

You can try matlm package if it meets your needs. I should say that matlm is experimental and I mainly developed it to implement custom models for my projects. It has documentation and examples, but it is even less official than lme4qtl.

@jfranco1951
Copy link

jfranco1951 commented Jun 17, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants