Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Product image urls is broken in order confirmation email #3130

Open
f0revery0ung opened this issue Oct 11, 2024 · 0 comments · May be fixed by #3131
Open

Product image urls is broken in order confirmation email #3130

f0revery0ung opened this issue Oct 11, 2024 · 0 comments · May be fixed by #3131
Labels
type: bug 🐛 Something isn't working

Comments

@f0revery0ung
Copy link

I think this change break image links in order confirmation email - e3d6c21#diff-ddc432c4392054b0d16b826194ca9e408576cee61292c9176f678919af6deb6fL1667

Standard order confirmation template expects order.lines.featuredAsset, but it is not loaded as relations in changed code
featuredAsset

const order = await this.findOne(
ctx,
orderId,
relations ?? [
'lines',
'lines.productVariant',
'lines.productVariant.productVariantPrices',
'shippingLines',
'surcharges',
'customer',
],
);
@f0revery0ung f0revery0ung added the type: bug 🐛 Something isn't working label Oct 11, 2024
nirzaf added a commit to nirzaf/vendure that referenced this issue Oct 13, 2024
@nirzaf
Fix broken product image URLs in order confirmation email
26d2ddd 
Fixes vendure-ecommerce#3130

Update the order service and resolver to include the `lines.featuredAsset` relation.

* **Order Service**
  - Add `lines.featuredAsset` to the relations array in the `findOne` method in `packages/core/src/service/services/order.service.ts`.

* **Order Resolver**
  - Add `lines.featuredAsset` to the relations array in the `order` query in `packages/core/src/api/resolvers/admin/order.resolver.ts`.
@nirzaf nirzaf linked a pull request Oct 13, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix broken product image URLs in order confirmation email nirzaf/vendure
1 participant
@f0revery0ung