Remove legacy interfaces, implement Vercel style interface (#132)

Previously there were two interfaces supported:

```ts
import { ServerRequest } from 'https://deno.land/[email protected]/http/server.ts';

export default function (request: ServerRequest) {
  console.log(request.url);
  request.respond({ body: '...' });
}
```

```ts
export default function (event: Deno.RequestEvent) {
  console.log(event.request.url);
  event.respondWith(new Response('...'));
}
```

Supporting both interfaces has been hard/hacky to maintain, and in 2023 there is a now a more standardized interface that also fits better with the Vercel style. This PR implements this new interface:

```ts
export default function (request: Request) {
  console.log(request.url);
  return new Response('...');
}
```

This new interface matches the Vercel Edge runtime syntax. The `Request` object is passed directly as the first parameter, and a `Response` instance is expected to be returned from the handler. The runtime is a lot cleaner because the legacy code has been removed. There are also less URL imports needed since Deno supports these standard classes directly (only `base64` still needs to be imported).

Closes #104.

Author: TooTallNate

api/dump.ts

@@ -1,21 +1,9 @@
 #!/usr/bin/env deno run --location https://example.com/page
 import ms from 'https://esm.sh/[email protected]';
-import { readerFromStreamReader } from 'https://deno.land/[email protected]/io/streams.ts';
-
-interface HeadersObject {
-	[name: string]: any;
-}
+import type { Handler } from "https://deno.land/[email protected]/http/server.ts";
 
 const startTime = new Date();
 
-function headersToObject(headers: Headers): HeadersObject {
-	const obj: HeadersObject = {};
-	for (const [name, value] of headers.entries()) {
-		obj[name] = value;
-	}
-	return obj;
-}
-
 function urlToObject(url: URL) {
 	return {
 		href: url.href || undefined,
@@ -32,7 +20,7 @@ function urlToObject(url: URL) {
 	};
 }
 
-function sortObject<T extends object>(obj: T): T {
+function sortObject<T extends Record<string, unknown>>(obj: T): T {
 	const sorted: T = Object.create(Object.getPrototypeOf(obj));
 	const keys = Object.keys(obj).sort() as (keyof T)[];
 	for (const k of keys) {
@@ -41,7 +29,7 @@ function sortObject<T extends object>(obj: T): T {
 	return sorted;
 }
 
-export default async ({ request }: Deno.RequestEvent) => {
+const handler: Handler = async (request) => {
 	const now = new Date();
 	const uptime = now.getTime() - startTime.getTime();
 	const url = new URL(request.url);
@@ -55,6 +43,8 @@ export default async ({ request }: Deno.RequestEvent) => {
 		}
 	}
 
+	const reqBody = await request.arrayBuffer();
+
 	const body = {
 		now: now.getTime(),
 		bootup: startTime.getTime(),
@@ -65,14 +55,11 @@ export default async ({ request }: Deno.RequestEvent) => {
 		request: {
 			method: request.method,
 			url: urlToObject(url),
-			headers: sortObject(headersToObject(request.headers)),
-			body: request.body
-				? new TextDecoder().decode(
-						await Deno.readAll(
-							readerFromStreamReader(request.body.getReader())
-						)
-				  )
-				: null,
+			headers: sortObject(Object.fromEntries(request.headers)),
+			body:
+				reqBody.byteLength > 0
+					? new TextDecoder().decode(reqBody)
+					: null,
 		},
 		response: {
 			status,
@@ -95,3 +82,5 @@ export default async ({ request }: Deno.RequestEvent) => {
 		},
 	});
 };
+
+export default handler;

api/dynamic-import.ts

@@ -1,6 +1,6 @@
 #!/usr/bin/env DENO_DIR=/tmp deno run --include-files ../util/**/*
 
-export default async ({ request }: Deno.RequestEvent) => {
+export default async (request: Request) => {
 	const name = new URL(request.url).searchParams.get('name') ?? 'a';
 	const mod = await import(`../util/${name}.ts`);
 	console.log({ name, mod });

api/javascript.js

@@ -1,3 +1,3 @@
-export default (req) => {
-	req.respond({ body: 'Hello from JavaScript in Deno!' });
+export default (_req) => {
+	return new Response('Hello from JavaScript in Deno!');
 };

api/oak.ts

@@ -1,10 +1,9 @@
-import { Application } from 'https://deno.land/x/oak@v9.0.0/mod.ts';
+import { Application } from 'https://deno.land/x/oak@v11.1.0/mod.ts';
 
 const app = new Application();
 
 app.use((ctx) => {
-	ctx.response.body = 'Hello World!';
-	console.log(ctx);
+	ctx.response.body = 'Hello World from Oak!';
 });
 
 export default app.handle;

src/runtime/dev-server.ts

@@ -1,5 +1,7 @@
 import { writeAllSync } from 'https://deno.land/[email protected]/streams/conversion.ts';
+import type { Handler, ConnInfo } from "https://deno.land/[email protected]/http/server.ts";
 
+// deno-lint-ignore no-explicit-any
 function isNetAddr(v: any): v is Deno.NetAddr {
 	return v && typeof v.port === 'number';
 }
@@ -9,24 +11,24 @@ const entrypoint = Deno.env.get('VERCEL_DEV_ENTRYPOINT');
 Deno.env.delete('VERCEL_DEV_ENTRYPOINT');
 
 const mod = await import(`file://${entrypoint}`);
-const handler = mod.default;
+const handler: Handler = mod.default;
 if (typeof handler !== 'function') {
 	throw new Error('Failed to load handler function');
 }
 
 // Spawn HTTP server on ephemeral port
-const conn = await Deno.listen({ port: 0 });
+const listener = Deno.listen({ port: 0 });
 
-if (isNetAddr(conn.addr)) {
-	const { port } = conn.addr;
+if (isNetAddr(listener.addr)) {
+	const { port } = listener.addr;
 	const portBytes = new TextEncoder().encode(String(port));
 
 	try {
 		// Write the port number to FD 3
 		const portFd = Deno.openSync('/dev/fd/3', { read: false, write: true });
 		writeAllSync(portFd, portBytes);
 		Deno.close(portFd.rid);
-	} catch (err) {
+	} catch (_err) {
 		// This fallback is necessary for Windows
 		// See: https://github.com/denoland/deno/issues/6305
 		const portFile = Deno.env.get('VERCEL_DEV_PORT_FILE');
@@ -38,12 +40,15 @@ if (isNetAddr(conn.addr)) {
 	}
 }
 
-const s = Deno.serveHttp(await conn.accept());
 // Serve HTTP requests to handler function
+const conn = await listener.accept();
+const s = Deno.serveHttp(conn);
 for await (const req of s) {
-	Promise.resolve(handler(req)).then((res: Response | void) => {
-		if (res) {
-			return req.respondWith(res);
-		}
-	});
+	const connInfo: ConnInfo = {
+		localAddr: conn.localAddr,
+		remoteAddr: conn.remoteAddr,
+	};
+	Promise.resolve(handler(req.request, connInfo)).then((res: Response) =>
+		req.respondWith(res)
+	);
 }