make stringifying consistent

Author: lukesandberg

turbopack/crates/turbopack-ecmascript/src/analyzer/mod.rs

@@ -1994,7 +1994,7 @@ impl JsValue {
             }
             JsValue::Effectful(_, operand) => {
                 format!(
-                    "side-effectful({})",
+                    "effectful({})",
                     operand.explain_internal_inner(hints, indent_depth, depth, unknown_depth)
                 )
             }

turbopack/crates/turbopack-ecmascript/tests/analyzer/graph/logical/graph-explained.snapshot

@@ -12,7 +12,7 @@ d (const after eval) = !(x)
 
 e (const after eval) = !(!(x))
 
-n (const after eval) = ((side-effectful(r) && t["__esModule"]) ? t : {"default": t})
+n (const after eval) = ((effectful(r) && t["__esModule"]) ? t : {"default": t})
 
 r (const after eval) = {}
 

turbopack/crates/turbopack-ecmascript/tests/analyzer/graph/logical/resolved-effects.snapshot

@@ -26,4 +26,4 @@
 
 13 -> 14 free var = FreeVar(global)
 
-0 -> 15 conditional = side-effectful({})
+0 -> 15 conditional = effectful({})

turbopack/crates/turbopack-ecmascript/tests/analyzer/graph/logical/resolved-explained.snapshot

@@ -18,7 +18,7 @@ d = false
 
 e = true
 
-n = ((side-effectful({}) | ???*0* | undefined | ???*2*) ? (???*3* | {}) : {"default": (???*4* | {})})
+n = ((effectful({}) | ???*0* | undefined | ???*2*) ? (???*3* | {}) : {"default": (???*4* | {})})
 - *0* ???*1*["__esModule"]
   ⚠️  unknown object
 - *1* t