From 950b45c5ee6989b3d8cc882190d8bab380a8e505 Mon Sep 17 00:00:00 2001 From: mitul-s Date: Thu, 16 Jul 2026 18:50:46 -0400 Subject: [PATCH 1/3] cool --- .../components/split-pane.tsx | 20 ++++-- .../components/trace-shortcut-helper.tsx | 2 +- .../new-trace-viewer/trace-viewer.tsx | 62 ++++++++++--------- 3 files changed, 49 insertions(+), 35 deletions(-) diff --git a/packages/web-shared/src/components/new-trace-viewer/components/split-pane.tsx b/packages/web-shared/src/components/new-trace-viewer/components/split-pane.tsx index 24df7f84cf..9bdc4fb528 100644 --- a/packages/web-shared/src/components/new-trace-viewer/components/split-pane.tsx +++ b/packages/web-shared/src/components/new-trace-viewer/components/split-pane.tsx @@ -36,10 +36,10 @@ export function SplitPane({ scrollContainerRef, }: SplitPaneProps) { const parts = Children.toArray(children); - if (parts.length !== 2) { - throw new Error('SplitPane expects exactly two children'); + if (parts.length < 2 || parts.length > 3) { + throw new Error('SplitPane expects two or three children'); } - const [start, end] = parts; + const [start, end, endOverlay] = parts; const [startPx, setStartPx] = useState(DEFAULT_START_PX); const containerRef = useRef(null); @@ -85,7 +85,7 @@ export function SplitPane({ ); return ( -
+
{end}
+ {endOverlay ? ( +
+
+
+
+ {endOverlay} +
+
+ ) : null}
); } diff --git a/packages/web-shared/src/components/new-trace-viewer/components/trace-shortcut-helper.tsx b/packages/web-shared/src/components/new-trace-viewer/components/trace-shortcut-helper.tsx index 84eee9c7d5..e346929bf3 100644 --- a/packages/web-shared/src/components/new-trace-viewer/components/trace-shortcut-helper.tsx +++ b/packages/web-shared/src/components/new-trace-viewer/components/trace-shortcut-helper.tsx @@ -86,7 +86,7 @@ export function TraceShortcutHelper({ }; return ( -
+
+
+ <> 1} reducedMotion={reducedMotion} /> -
+
+ + + + + + + + + +
+ -
- - - - - - - - - -
Date: Thu, 16 Jul 2026 18:53:00 -0400 Subject: [PATCH 2/3] Update split-pane.tsx --- .../components/split-pane.tsx | 24 +++++++++---------- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/packages/web-shared/src/components/new-trace-viewer/components/split-pane.tsx b/packages/web-shared/src/components/new-trace-viewer/components/split-pane.tsx index 9bdc4fb528..016eb30459 100644 --- a/packages/web-shared/src/components/new-trace-viewer/components/split-pane.tsx +++ b/packages/web-shared/src/components/new-trace-viewer/components/split-pane.tsx @@ -36,8 +36,8 @@ export function SplitPane({ scrollContainerRef, }: SplitPaneProps) { const parts = Children.toArray(children); - if (parts.length < 2 || parts.length > 3) { - throw new Error('SplitPane expects two or three children'); + if (parts.length !== 3) { + throw new Error('SplitPane expects exactly three children'); } const [start, end, endOverlay] = parts; @@ -126,18 +126,16 @@ export function SplitPane({
{end}
- {endOverlay ? ( -
-
-
-
- {endOverlay} -
+
+
+
+
+ {endOverlay}
- ) : null} +
); } From cd2efa37f1a00238ef4ff65cd00aace6f4b5f81e Mon Sep 17 00:00:00 2001 From: Mitul Shah Date: Thu, 16 Jul 2026 18:54:16 -0400 Subject: [PATCH 3/3] Create fruity-cars-slide.md Signed-off-by: Mitul Shah --- .changeset/fruity-cars-slide.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/fruity-cars-slide.md diff --git a/.changeset/fruity-cars-slide.md b/.changeset/fruity-cars-slide.md new file mode 100644 index 0000000000..5b1b0e1b08 --- /dev/null +++ b/.changeset/fruity-cars-slide.md @@ -0,0 +1,5 @@ +--- +"@workflow/web-shared": patch +--- + +Adjust helper position on trace viewer