[Spelling] Fixed Simple Spelling Mistakes in Route Dir #3360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
VPR
Contributor
|
I reorganized the RR graph generation code by moving related functions into new files. |
Contributor
|
Agreed, I think waiting for #3323 to be merged before doing this would be the best approach. |
This is the last of the simple spelling mistakes in the VPR directory. The rest are variable name changes which are not hard, but should be isolated into their own commits. NOTE: The rr_graph.cpp and rr_graph2.cpp files were left behind to prevent issues with currently open PRs.
AlexandreSinger
force-pushed
the
feature-spelling
branch
from
f1fd163 to
a481ad7
Compare
Contributor
Author
|
@soheilshahrouz @AmirhosseinPoolad I have undone my changes to The changes were squashed as well. |
Contributor
|
Thanks @AlexandreSinger |
Contributor
AmirhosseinPoolad
left a comment
AmirhosseinPoolad
left a comment
There was a problem hiding this comment.
Thanks @AlexandreSinger. some small issues but looks good otherwise.
vpr/src/route/rr_graph_generation/tileable_rr_graph/tileable_rr_graph_gsb.cpp
Outdated
Show resolved
Hide resolved
vpr/src/route/rr_graph_generation/tileable_rr_graph/tileable_rr_graph_gsb.cpp
Outdated
Show resolved
Hide resolved
vpr/src/route/rr_graph_generation/tileable_rr_graph/tileable_rr_graph_gsb.cpp
Outdated
Show resolved
Hide resolved
vpr/src/route/rr_graph_generation/tileable_rr_graph/tileable_rr_graph_gsb.cpp
Outdated
Show resolved
Hide resolved
| #ifndef NON_DETERMINISTIC_PRUNING | ||
| // With deterministic pruning, cannot always prune on ties. | ||
| // In the case of a true tie, just prune, no need to explore neightbors | ||
| // In the case of a true tie, just prune, no need to explore neighbors |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last of the simple spelling mistakes in the VPR directory. The rest are variable name changes which are not hard, but should be isolated into their own commits.