Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: The step Hook vfox to your Shell should mention that a new terminal needs to be opened for the script to work #434

Closed
linghengqian opened this issue Mar 19, 2025 · 2 comments · Fixed by #436
Labels
enhancement New feature or request

Comments

@linghengqian
Copy link
Contributor

1. Your usage scenarios?

  • I was just testing the difference between vfox and sdkman!.

2. What is your expected outcome?

  • The step for Hook vfox to your Shell should mention the need to open a new terminal for the script to work. I'm referring to https://vfox.dev/guides/quick-start.html#_2-hook-vfox-to-your-shell .
  • Image
  • At least for Windows 11, after executing if (-not (Test-Path -Path $PROFILE)) { New-Item -Type File -Path $PROFILE -Force }; Add-Content -Path $PROFILE -Value 'Invoke-Expression "$(vfox activate pwsh)"' in PowerShell 7, vfox is not available in the current PowerShell terminal. I need to open a new PowerShell 7 terminal to make it work.
  • It might be better to add a hint like Afterward, open a new terminal. to the documentation. Just like https://sdkman.io/install .
@linghengqian linghengqian added the enhancement New feature or request label Mar 19, 2025
@bytemain
Copy link
Member

good point, PR is welcome

@linghengqian
Copy link
Contributor Author

good point, PR is welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants