Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] Ensure CI does not submit a new package version to homebrew without a Github Release #32365

Closed
chenrui333 opened this issue Sep 5, 2024 · 4 comments · Fixed by #32433
Closed

[bug] Ensure CI does not submit a new package version to homebrew without a Github Release #32365

chenrui333 opened this issue Sep 5, 2024 · 4 comments · Fixed by #32433
Assignees
@esolitos

Comments

@chenrui333
Copy link
Contributor

👋 looks like 8.405.15 did not get marked as latest release, raise this issue for some awareness. Thanks!

relates to Homebrew/homebrew-core#183574
@chenrui333 chenrui333 mentioned this issue Sep 5, 2024
Merged
@esolitos
Copy link
Contributor

esolitos commented Sep 6, 2024

Thanks, fixed! 😊
https://github.com/vespa-engine/vespa/releases/tag/v8.405.15

@esolitos esolitos closed this as completed Sep 6, 2024
@esolitos esolitos changed the title 8.405.15 did not get marked as latest release Vespa CLI 8.405.15 did not get marked as latest release Sep 6, 2024
@chenrui333
Copy link
Contributor Author

thanks @esolitos!

@chenrui333
Copy link
Contributor Author

@esolitos looks like same thing happens for 8.410.10 rel, Homebrew/homebrew-core#191085

@esolitos
Copy link
Contributor

Indeed 😞
I'll make sure to fix this tomorrow.

@esolitos esolitos reopened this Sep 18, 2024
@esolitos esolitos changed the title Vespa CLI 8.405.15 did not get marked as latest release [bugEnsure Sep 18, 2024
@esolitos esolitos changed the title [bugEnsure [bug] Ensure CI does not submit a new package version to homebrew without a Github Release Sep 18, 2024
@esolitos esolitos mentioned this issue Sep 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@esolitos esolitos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(cli): only publish if changes detected since last release vespa-engine/vespa
2 participants
@esolitos @chenrui333