Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix koan AboutCsvCmdlets (#439) #440

Merged
merged 2 commits into from
May 1, 2021
Merged

Conversation

peetrike
Copy link
Contributor

@peetrike peetrike commented Apr 29, 2021

PR Summary

Fixes 2 problems mentioned in #439

Fixes #439

Context

Changes

Checklist

  • Pull Request has a meaningful title.
  • Summarised changes.
  • Pull Request is ready to merge & is not WIP.
  • Added tests / only testable interactively.
    • Make sure you add a new test if old tests do not effectively test the code changed.
  • Added documentation / opened issue to track adding documentation at a later date.

@peetrike peetrike changed the title 🐛 Fix koan AboutPsProviders (#436) 🐛 Fix koan AboutPsProviders (#439) Apr 29, 2021
@peetrike peetrike changed the title 🐛 Fix koan AboutPsProviders (#439) 🐛 Fix koan AboutCsvCmdlets (#439) Apr 29, 2021
@peetrike peetrike marked this pull request as ready for review April 29, 2021 07:10
@peetrike
Copy link
Contributor Author

peetrike commented Apr 29, 2021

Also, the content of that It block is missing from published module

Copy link
Owner

@vexx32 vexx32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sorting this out! 💖

Yeah, there's a few things in the repo here that aren't in the public module version, I'm planning to release a new module version at some point in the near future. I've been hesitant to push a new release since I migrated this module to Pester v5 as we haven't been able to fully test all the new functionality. That should be resolved with an upcoming Pester version fairly soon, so we should be able to get a new release in the coming weeks. 🙂

@vexx32 vexx32 merged commit 23455f7 into vexx32:main May 1, 2021
@peetrike peetrike deleted the AboutCsvCmdlets branch May 3, 2021 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Two typos in koan AboutCsvCmdlets
2 participants