Skip to content

Toolitems Images Cutoff on dragging to the vertical toolbar #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
amartya4256 opened this issue Jan 2, 2025 · 3 comments
Closed

Toolitems Images Cutoff on dragging to the vertical toolbar #178

amartya4256 opened this issue Jan 2, 2025 · 3 comments
Assignees
Labels
HiDPI/Integer200 HiDPI issues specific to using "integer" or "integer200" scaling mode HiDPI A HiDPI-Related Issue or Feature SWT Issue for SWT
Milestone

Comments

@amartya4256
Copy link

amartya4256 commented Jan 2, 2025

Toolitems: cut off in horizontal placement if dragged from horizontal to vertical and dragged out without dropping and then put it back in vertical position. Fixes on moving the ide back and forth between monitors. Probably related to Federico's bug no. 1.
image

@amartya4256 amartya4256 changed the title Toolitems: cut off in horizontal placement if dragged from horizontal to vertical and dragged out without dropping and then put it back in vertical position. Fixes on moving the ide back and forth between monitors. Probably related to Federico's bug no. 1. Toolitems Images Cutoff on dragging to the vertical toolbar Jan 2, 2025
@HeikoKlare HeikoKlare added SWT Issue for SWT HiDPI A HiDPI-Related Issue or Feature labels Jan 9, 2025
@HeikoKlare HeikoKlare added this to HiDPI Jan 9, 2025
@HeikoKlare HeikoKlare moved this to 🔖 Ready: Atomic in HiDPI Jan 9, 2025
@HeikoKlare HeikoKlare added this to the 4.35 M3 milestone Jan 13, 2025
@HeikoKlare
Copy link
Contributor

Still reproducible on today's master state:
image

Setup:

  • 3 monitors:
    • Left 100% Secondary
    • Middle 175% Secondary
    • Right 100% Primary

Workflow:

  • Move application to middle monitor
  • Drag a toolbar to a vertical stack (e.g., the left side) so that it shows the preview of inserting it (now it probably looks fine), don't drop it but move it away (now you should see a preview vertical toolbar that is cut off) and the try to drop it at the left side again.

Infos:

  • I can only reproduce it in my host SDK, not in a runtime application
  • The workflow is non-deterministic, sometimes I face the issue and sometimes I don't
  • I would expect this to not occur anymore when we exclude integer200

So in case no one can reproduce this easily, I propose to close this as an integer200-specific issue and see in further testing sessions whether we will face it again. Any objections?

@HeikoKlare HeikoKlare modified the milestones: 4.35 M3, 4.36 M1, 4.36 M3 Jan 14, 2025
@HeikoKlare HeikoKlare modified the milestones: 4.36 M3, 4.36 M2 Feb 24, 2025
@ShahzaibIbrahim ShahzaibIbrahim moved this from 🔖 Ready: Atomic to 🏗 In Work: Short in HiDPI Apr 28, 2025
@ShahzaibIbrahim ShahzaibIbrahim self-assigned this Apr 28, 2025
@amartya4256
Copy link
Author

I have tried many combinations here and they all seem to work fine. Would someone else also verify please? @akoch-yatta @HeikoKlare @fedejeanne @ShahzaibIbrahim
Things I tried:

  • All the reproducers mentioned above both on the current RCP and runtime (I have the latest SWT master)
  • Tried primary monitors at 100, 125, 150, 175.

@HeikoKlare HeikoKlare added the HiDPI/Integer200 HiDPI issues specific to using "integer" or "integer200" scaling mode label Apr 29, 2025
@HeikoKlare
Copy link
Contributor

I cannot reproduce it either and since it seems to have been int200-specific (see #178 (comment)), we may not face it anymore unless we allow int200 scaling for monitor-specific scaling. I have also tested with a defined scale value (-Dswt.autoScale=175) and was also not able to reproduce it.

So, I've just added the according Integer200label and close this as non reproducible with the configurations that we allow.

@HeikoKlare HeikoKlare closed this as not planned Won't fix, can't repro, duplicate, stale Apr 29, 2025
@github-project-automation github-project-automation bot moved this from 🏗 In Work: Short to ✅ Done in HiDPI Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HiDPI/Integer200 HiDPI issues specific to using "integer" or "integer200" scaling mode HiDPI A HiDPI-Related Issue or Feature SWT Issue for SWT
Projects
Status: Done
Development

No branches or pull requests

3 participants