Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add React 19 Compatibility for mui-color-input #54

Closed
nlivenketan opened this issue Jan 2, 2025 · 2 comments
Closed

Comments

@nlivenketan
Copy link

Feature Request: Add React 19 Compatibility for mui-color-input

Currently, mui-color-input supports React versions up to 18. However, I am using React 19 in my project and would like to continue using this component. Could you please update the component to support React 19 in the peerDependencies so that the build can proceed without errors?

Additional Context:

  • I'm using React 19 in my project, and everything works fine except for the build failure caused by missing peerDependencies.
  • The peerDependencies in the package.json need to be updated to include React 19.
  • If the peerDependencies are updated, the build will succeed without issues.

If you need any help testing or if you'd like me to provide further details on the issues I'm facing, feel free to reach out!

Expected Outcome:

  • The component should be compatible with React 19 without breaking any existing functionality and allow successful builds.

Thank you!

@viclafouch
Copy link
Owner

Duplicate with #53

@viclafouch viclafouch closed this as not planned Won't fix, can't repro, duplicate, stale Jan 2, 2025
@nlivenketan
Copy link
Author

nlivenketan commented Jan 3, 2025

Dear @viclafouch,

Thank you for your suggestion to force-install the plugin. However, I am currently using GitHub Actions with npm CLI to manage my builds. When I attempt to build the project using this setup, the process fails due to peer dependency conflicts.

Even though forcing the plugin installation locally might work temporarily, it is not a viable solution in a CI/CD environment where dependency management needs to be strict to ensure stability and reproducibility.

Could you please update the peerDependencies in the plugin's package.json to include support for the latest React version (React 19)? This would allow the build to proceed seamlessly without needing to bypass dependency checks.

Thank you for your support and for considering this request. Please let me know if I can assist with testing or provide additional details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants