Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache issue when checking modified files #11093

Open
Vitamin4iK-afk opened this issue Sep 9, 2024 · 4 comments
Open

Cache issue when checking modified files #11093

Vitamin4iK-afk opened this issue Sep 9, 2024 · 4 comments

Comments

@Vitamin4iK-afk
Copy link

I encountered a problem with Psalm cache when checking modified files.

During code inspection Psalm reported error: ERROR: PossiblyInvalidMethodCall - file:line:position - Cannot call method on possible array<array-key, int> variable (see https://psalm.dev/113). I fixed this error and re-run code inspection, but Psalm still reports this error. Only when I cleared cache with psalm --clear-cache the error stopped appearing on further inspections.

Steps to Reproduce:
I managed to make a minimal repository to reproduce this problem: https://github.com/Vitamin4iK-afk/psalm-test.

  1. Checkout initial commit.
  2. Clear Psalm cache with psalm --clear-cache.
  3. Run code inspection. This correctly reports error.
  4. Checkout latest commit.
  5. Run code inspection again. This falsely reports already fixed error.

System Information:
Operating System: Ubuntu 22.04.4 LTS
PHP Version: 8.2.22, 8.3.11
Psalm Version: 5.25.0

Additional Information:
Clearing Psalm cache resolves the problem but significantly increases inspection time and is not suitable for large repositories.

Copy link

Hey @Vitamin4iK-afk, can you reproduce the issue on https://psalm.dev? These will be used as phpunit tests when implementing the feature or fixing this bug.

@Vitamin4iK-afk
Copy link
Author

Vitamin4iK-afk commented Sep 9, 2024

Hey @Vitamin4iK-afk, can you reproduce the issue on https://psalm.dev? These will be used as phpunit tests when implementing the feature or fixing this bug.

No. This issue can`t be reproduced on https://psalm.dev/ because to reproduce it you need to follow certain steps described in the issue.

@weirdan
Copy link
Collaborator

weirdan commented Sep 9, 2024

Reproduced as described.

@theodorejb
Copy link
Contributor

I encounter this issue so frequently when switching between branches/commits, that I can rarely run Psalm successfully without manually clearing the cache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants