Skip to content

Commit 66dc858

Browse files
committed
Updated README
1 parent 0e00dd4 commit 66dc858

File tree

3 files changed

+5
-48
lines changed

3 files changed

+5
-48
lines changed

advice-generator-app-react/README.md

Lines changed: 1 addition & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ Your users should be able to:
3939

4040
### What I learned and continuous development
4141

42-
_WIP_
42+
This was quick and small project. Just to practice more of styled components.
4343

4444
### Installation
4545

@@ -69,24 +69,3 @@ yarn preview
6969
### Useful resources
7070

7171
ViteJS - https://vitejs.dev/guide/#scaffolding-your-first-vite-project
72-
73-
## TODO
74-
75-
_This list will be removed once everything is checked or project is considered as completed_
76-
77-
### Basic
78-
79-
- [ ] Update the file/folder structure
80-
- [ ] Bring the data from the starter code
81-
- [ ] Build the necessary components
82-
83-
### Styling
84-
85-
- [ ] Create a globalstyle
86-
- [ ] Convert all tags to styled components
87-
- [ ] Add aria tags to buttons
88-
- [ ] Media Queries
89-
90-
### Extra
91-
92-
### Repo

intro-section-with-dropdown-navigation-react/README.md

Lines changed: 4 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,9 @@ Your users should be able to:
2727

2828
### What I learned and continuous development
2929

30-
_WIP_
30+
The navigation in react and styled components together was a little tricky to understand. Especially handling the dropdown nav items.
31+
I ended up creating a data file for dropdown items to handle them easily but I am not sure this is the correct approach to it.
32+
The mobile nav can be drastically improved.
3133

3234
### Installation
3335

@@ -58,28 +60,4 @@ npm run preview
5860

5961
ViteJS - https://vitejs.dev/guide/#scaffolding-your-first-vite-project
6062

61-
## TODO
62-
63-
_This list will be removed once everything is checked or project is considered as completed_
64-
65-
### Basic
66-
67-
- [ ] Update the file/folder structure
68-
- [ ] Bring in the data from the starter code
69-
- [ ] Build the necessary components
70-
- [ ] Add a onclick wherever necessary to close dropdown if link is clicked or any other place clicked
71-
72-
### Styling
73-
74-
- [ ] Convert all tags to styled components
75-
- [ ] Add aria tags to buttons especially dropdown (read more)
76-
- [ ] Conditional dropdown rendering
77-
- [ ] Media Queries
78-
- [ ] Mobile Nav
79-
80-
### Extra
81-
82-
### Repo
83-
84-
- [ ] Add resources, hurdles and a small write up about experience
85-
- [ ] Update parent README with updated project status
63+

intro-section-with-dropdown-navigation-react/src/components/DropdownMenu.styles.js

Whitespace-only changes.

0 commit comments

Comments
 (0)