ignorekeys doesn't work in 3.16.0

[ArturDorochowicz]

Issue type:

• Bug report

Version:

Vimperator:	3.16.0 (created: 2017/02/01 00:55:15)
Firefox:	Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:50.0) Gecko/20100101 Firefox/50.0

Description:

Ignorekeys stopped working (they don't get enabled at all) in 3.16.0
After downgrading back to 3.15.0 things work just fine.

Expected behavior:

Ignorekeys should get enabled on matching site.

Steps to reproduce:

:open https://en.wikipedia.org/wiki/Vimperator
:ignorekeys add en\\.wikipedia\\.org
:reload

Observe that ignorekeys is not enabled.

Note that ignorekeys list includes the configured site correctly.

[yayugu]

same problem on

Vimperator:	3.16.0 (created: 2017/02/01 00:55:15)
Firefox:	Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:50.0) Gecko/20100101 Firefox/50.0

[SammysHP]

Can you please test with current version of Firefox (51)? There were some changes in that area that might be not backwards compatible (the other possibility is that it won't work for both versions and that the new code is really broken).

[pinetreegator]

I was experiencing this problem in Firefox 50 but after I upgraded to FF 51 the ignorekeys function works again.

[ArturDorochowicz]

I'll try to check with FF51 ASAP then. For some reason my Ubuntu install stopped getting updates, that's why I'm on 50 still. I guess, I will have to resolve that first.

[SammysHP]

Thanks for testing. This might be relevant for the ESR version as well.

Probably caused by eabb291.

[ArturDorochowicz]

@SammysHP I can confirm that it works in Firefox 51.

The issue can be closed as far as I am concerned. Thanks!

[skrattaren]

Is there any plan to fix this (and #724) for ESR?