Firefox 56 compatibility

[SammysHP]

There are some deprecation warnings (not necessary to fix because FF56 will be the last version that is compatible with Vimperator) as well as some major bugs:

Bugs:

• NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIProtocolHandler.newChannel]
  This causes FF 56: Command suggestions background is transparent #777 and Open link hotkey not showing matches #786 and the missing help. Required for adding chrome-data and help scheme.
• .textbox-search-icons renamed to .textbox-search-sign
• TypeError: this._identityPopupContentHosts is undefined
  SSL popup not shown

Warnings:

• DEPRECATION WARNING: Search service falling back to synchronous initialization. This is generally the consequence of an add-on using a deprecated search service API.
  You may find more details about this deprecation at: https://developer.mozilla.org/en-US/docs/XPCOM_Interface_Reference/nsIBrowserSearchService#async_warning
• JavaScript 1.6's for-each-in loops are deprecated; consider using ES6 for-of instead
• String.localeCompare is deprecated; use String.prototype.localeCompare instead
• String.replace is deprecated; use String.prototype.replace instead
• String.toLowerCase is deprecated; use String.prototype.toLowerCase instead

[SammysHP]

I tried to fix the protocol handler bug for several hours without success. The problem is in common/components/protocol.js:

let channel = Components.classesByID["{61ba33c0-3031-11d3-8cd0-0060b0fc14a3}"]
                        .getService(Ci.nsIProtocolHandler)
                        .newChannel(ioService.newURI("chrome://liberator/content/data", null, null))
                        .QueryInterface(Ci.nsIRequest);

and fails with NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIProtocolHandler.newChannel].

We need help!

[SammysHP]

Actually I'm rather happy that this broke! IMHO the chrome-data protocol handler is a big security issue because it might allow websites to gain chrome privileges. But I might be wrong.

[kyao-777]

@SammysHP what's the meaning of the FF56 will be the last version that is compatible with Vimperator. You cannot update the vimperator for firefox in the future. Sorry, my english is bad.

[SammysHP]

@kyao-777
Please read #705.

[kyao-777]

@SammysHP thanks

[JinhaoPro]

My English is not quite good, but is there anyone who can tell me how to solve #786 problem?

[SammysHP]

You have to build an XPI from the ff56-fixes branch yourself and use it with a custom built version of Firefox that does not enforce signature verification. Official update might take a few weeks.