Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValidationError uses V8's stack trace API which breaks on Firefox #49

Open
simoneNEMO opened this issue Apr 29, 2024 · 3 comments
Open

Comments

@simoneNEMO
Copy link
Contributor

simoneNEMO commented Apr 29, 2024

Package version

v2.0.0

Describe the bug

Since you recently made some efforts to bring VineJS from Node to the Browser (h/t @Julien-R44) I wanted to flag that ValidationError uses Error.captureStackTrace which is a feature from V8's stack trace API and breaks on non V8 environments like Firefox.

Of course I understand VineJS is still officially a Node library but it is great to use on the Browser side as well, especially since it is already almost fully compatible.

Reproduction repo

No response

@thetutlage
Copy link
Contributor

What's the alternative to using Error.captureStackTrace in cross-browser environment?

@simoneNEMO
Copy link
Contributor Author

There is indeed no decent solution but seems most of codebases out there that want to be cross-browser engine compatible use something like this.

Of course is not the job of VineJS to adapt to every browser but opened this issue for awareness and to start the conversation.

@lahgolz
Copy link

lahgolz commented Jul 12, 2024

Is this planned? I fixed the issue on one of my projects using Yarn's patch feature, but now contributors can only use Yarn when working on it because it uses a protocol unknown to other package managers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants