Skip to content

Commit 6c921d7

Browse files
committed
Minor refactoring
1 parent e72128e commit 6c921d7

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

src/main/java/in/erail/amazon/lambda/AWSLambda.java

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
import com.google.common.base.Strings;
77
import com.google.common.io.ByteStreams;
88
import in.erail.glue.Glue;
9+
import in.erail.glue.common.Util;
910
import in.erail.model.Event;
1011
import in.erail.service.RESTService;
1112
import io.reactivex.Single;
@@ -32,8 +33,7 @@
3233
public class AWSLambda implements RequestStreamHandler {
3334

3435
protected Logger log = LogManager.getLogger(AWSLambda.class.getCanonicalName());
35-
private static final String SERVICE_ENV = "SERVICE";
36-
private static final String SERVICE_SYS_PROP = "service";
36+
private static final String SERVICE_ENV = "service";
3737
private final RESTService mService;
3838
private final List<String> allowedFields = new ArrayList<>();
3939

@@ -45,17 +45,18 @@ public AWSLambda() {
4545
allowedFields.add("multiValueHeaders");
4646
allowedFields.add("body");
4747

48-
String component = System.getenv(SERVICE_ENV);
49-
if (Strings.isNullOrEmpty(component)) {
50-
component = System.getProperty(SERVICE_SYS_PROP);
51-
}
48+
String component = Util.getEnvironmentValue(SERVICE_ENV);
5249

50+
if(Strings.isNullOrEmpty(component)) {
51+
throw new RuntimeException("Service not defined in lambda environment");
52+
}
53+
5354
mService = Glue.instance().resolve(component);
5455
}
5556

5657
@Override
5758
public void handleRequest(InputStream inputStream, OutputStream outputStream, Context context) throws IOException {
58-
try (OutputStreamWriter writer = new OutputStreamWriter(outputStream, "UTF-8")) {
59+
try ( OutputStreamWriter writer = new OutputStreamWriter(outputStream, "UTF-8")) {
5960
JsonObject requestJson = new JsonObject(Buffer.buffer(ByteStreams.toByteArray(inputStream)));
6061
log.debug(() -> requestJson.toString());
6162
String resp = handleMessage(requestJson).blockingGet();

0 commit comments

Comments
 (0)