Skip to content

Eslint + Prettier conflicts #25

Description

@ra-phael

As part of #23
some errors appeared that seem to be a conflict between Prettier and ESLint in the following files:

files: ['src/constants/chains.ts', 'src/constants/locales.ts', 'src/state/routing/utils.ts'],

I didn't dive into the issue as the eslint configuration comes from @uniswap/eslint-config. I disabled the errors (see .eslintrc).

Description

  1. Although my IDE does not complain at first, running yarn lint reports errors in the files mentioned above. For example
export type SupportedL1ChainId = typeof L1_CHAIN_IDS[number]

should be replaced with

export type SupportedL1ChainId = (typeof L1_CHAIN_IDS)[number]

...src/constants/locales.ts
36:31 error Replace typeof·SUPPORTED_LOCALES with (typeof·SUPPORTED_LOCALES) prettier/prettier

  1. Run yarn lint --fix to fix these errors.

  2. Now my IDE complains
    image

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions