Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor JS #57

Closed
keller-mark opened this issue Feb 16, 2022 · 2 comments
Closed

Refactor JS #57

keller-mark opened this issue Feb 16, 2022 · 2 comments
Labels
for-bioconductor

Comments

@keller-mark
Copy link
Member

keller-mark commented Feb 16, 2022 •
edited
Loading

User story

JS bundle is huge.

Preferred solution

Remove merge_js function by making JS bundle smaller or moving out of this repo.

  • Minify JS bundle by updating webpack configuration.

Possible alternatives

  • Publish the JS bundle for the htmlwidget to NPM, then somehow load from a CDN in the htmlwidget.
@keller-mark
Copy link
Member Author

Related to #55

@keller-mark keller-mark mentioned this issue Apr 17, 2022
Merged
@keller-mark keller-mark mentioned this issue May 25, 2022
Merged
@keller-mark
Copy link
Member Author

Fixed by #63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
for-bioconductor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@keller-mark