Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Report: getAllTablets in go/vt/vtorc/logic does not handle partial-cell results ideally #17719

Closed
timvaillancourt opened this issue Feb 8, 2025 · 0 comments · Fixed by #17718
Closed

Bug Report: getAllTablets in go/vt/vtorc/logic does not handle partial-cell results ideally #17719

timvaillancourt opened this issue Feb 8, 2025 · 0 comments · Fixed by #17718
Assignees
@timvaillancourt
Labels
Component: VTorc Vitess Orchestrator integration Type: Bug

Comments

@timvaillancourt
Copy link
Contributor

Overview of the Issue

When a single cell fails to return tablets in getAllTablets it can cause refreshTabletsUsing() (from same file) to "forget" tablets that were unable to be loaded from topo

Reproduction Steps

  1. Run main VTOrc with many topos/cells
  2. Cause a single cell to be unable to refresh tablets
  3. Notice refreshes to the remaining cells cause tablet-records of the dead cells to be deleted in VTOrc's backend

Binary Version

v22/main as of now

Operating System and Environment details

N/A

Log Fragments


      		
    

      
  





        



            

              
            

        

      


      
    








      

    



      

  
            

    

      
    

    


      

          @timvaillancourt
timvaillancourt




            added
      

  Needs Triage

  This issue needs to be correctly labelled and triaged

      

  Type: Bug


  labels


      Feb 8, 2025

    

  



  

  

    
  


  

      

    @timvaillancourt
timvaillancourt



    mentioned this issue
    
      Feb 8, 2025
    





  


  

      
   Merged

  





  
  

      
        
      
      

  
    
    
  


    5 tasks
  





  




    

    

      
    

    


      

          @timvaillancourt
timvaillancourt




              self-assigned this


      Feb 8, 2025

    

  



    

    

      
    

    


      

          @timvaillancourt
timvaillancourt




            added
      

  Component: VTorc

  Vitess Orchestrator integration

    and removed
      

  Needs Triage

  This issue needs to be correctly labelled and triaged

  labels


      Feb 8, 2025

    

  



    

    











  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                  




    

  


      
  

    Assignees
  



        

      

        

  
      @timvaillancourt
  
    timvaillancourt
    

      








      


  


  

    Labels
  



    

      

    Component: VTorc

  Vitess Orchestrator integration
  

    Type: Bug









      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    
      

        
    

    Development
  




          
  
Successfully merging a pull request may close this issue.





    


  
          
      vtorc: improve handling of partial cell topo results

    
      timvaillancourt/vitess
    





    
  




      

    

  
      

  

    

      1 participant
    

    

        
          @timvaillancourt