Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redefine Skeleton's changedate #510

Open
sveneberth opened this issue Sep 16, 2022 · 5 comments
Open

Redefine Skeleton's changedate #510

sveneberth opened this issue Sep 16, 2022 · 5 comments
Assignees
Labels
feature New feature or request Priority: High After critical issues are fixed, these should be dealt with before any further issues.

Comments

@sveneberth
Copy link
Member

Ensure we have a trustworthy changedate, which should only be changed, if the values in the skeleton has been changed by the user. Otherwise keep the changedate the same, even after a .toDB().

Some notes from the brainstorming

  • trigger only by real changes from a user (not from e.g. a updateRelations task)
  • Create hashes for comparison?
  • Consider datastore changedate?
  • Updatemagic / Changedate only on real changes
@sveneberth sveneberth added the feature New feature or request label Sep 16, 2022
@sveneberth sveneberth self-assigned this Sep 16, 2022
@phorward
Copy link
Member

Relates to #785

@phorward
Copy link
Member

phorward commented Dec 7, 2023

Fixed by #785

@phorward phorward closed this as completed Dec 7, 2023
@sveneberth
Copy link
Member Author

which should only be changed, if the values in the skeleton has been changed

I don't think this is solved. We update the changedate on every toDB(), but also if there were no changes. Furthermore I don't know what happens if changedate isn't part of a subskel.

@sveneberth sveneberth reopened this Dec 8, 2023
@phorward
Copy link
Member

This could be resolved together with #478, as there is a comparison of the old and new dataset, and also an ignore list which skips specific bones when changed (e.g. changedate 😜)

@phorward phorward self-assigned this Feb 26, 2024
@phorward phorward added this to the ViUR-core v3.7 milestone Feb 26, 2024
@phorward phorward added Priority: High After critical issues are fixed, these should be dealt with before any further issues. viur-meeting Issues to discuss in the next ViUR meeting labels Oct 7, 2024
@phorward
Copy link
Member

viur-meeting: We should think about a second field for this date.

Scribble:

  • add_date
  • edit_date
  • write_date

@phorward phorward removed the viur-meeting Issues to discuss in the next ViUR meeting label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request Priority: High After critical issues are fixed, these should be dealt with before any further issues.
Projects
None yet
Development

No branches or pull requests

2 participants