Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Definition of isEmpty #531

Open
phorward opened this issue Oct 14, 2022 · 0 comments
Open

Definition of isEmpty #531

phorward opened this issue Oct 14, 2022 · 0 comments
Assignees

Comments

@phorward
Copy link
Member

phorward commented Oct 14, 2022

Hello, regarding the failing tests: This occurs when something different then a str is given to isEmpty.
A general question on this: Why can't isEmpty/isValid etc. just rely that the provided value is of the given type of the bone, which is parsed using fromClient? Either the tests must be changed, or the generic concept of VIUR. Well okay, I think this is a generall discussion topic, just fixing it now this way and see the rest later on.

Originally posted by @phorward in #514 (comment)

@phorward phorward self-assigned this Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant