Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"bounce"-parameter in add/edit - improve or remove? #555

Open
phorward opened this issue Nov 17, 2022 · 2 comments
Open

"bounce"-parameter in add/edit - improve or remove? #555

phorward opened this issue Nov 17, 2022 · 2 comments
Labels
discussion These topics must be discussed before completion refactoring Pull requests that refactor code but do not change its behavior.
Milestone
ViUR-core v4.0

Comments

@phorward
Copy link
Member

I'm not sure if the "bounce" parameter in various prototypes is still in use.

Either we could remove it, or we improve it as commented by @phorward in #548 (comment)_
@phorward phorward added discussion These topics must be discussed before completion refactoring Pull requests that refactor code but do not change its behavior. labels Nov 17, 2022
@sveneberth
Copy link
Member

IMO we should keep it. You can use it for validation from the frontend. But the idea with the boolean handling is good — maybe we can generalize in a parse_bool() method. Or we can simply add bounce as method parameter, so we can use the bool type hint.

@phorward
Copy link
Member Author

Improved by #838

@phorward phorward added this to the ViUR-core v4.0.0 milestone Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion These topics must be discussed before completion refactoring Pull requests that refactor code but do not change its behavior.
Projects
None yet
Milestone
ViUR-core v4.0
Development

No branches or pull requests
2 participants
@sveneberth @phorward