-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider switching back to Puppeteer from Playwright #553
Comments
There seems to be a rationale for switching to Puppeteer, but I would like to do some more research to decide implementation policy. |
About support for hyphens: auto, they seem to be adding it in Playwright v1.51. About PDF generation with Firefox, I got an answer from Playwright team: (microsoft/playwright#34406 (comment))
and the issue was closed as no plans. |
Seems like they won't add hyphens: auto support before Playwright v1.52: microsoft/playwright#34375 |
We switched from Puppeteer to Playwright in Vivliostyle CLI v5.0.0 (2022-06-06) because at that time Playwright had several advantages over Puppeteer.
See the pull request switching to Playwright:
However, now most of the issues with Puppeteer have been resolved, and it has some advantages over Playwright, especially:
Hypenation support on non-macOS platforms
Firefox support for PDF generation
The only limitation of Puppeteer, as far as I know, is that it does not support WebKit, but I don't think it is very important for Vivliostyle CLI only for previewing.
The text was updated successfully, but these errors were encountered: