Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider switching back to Puppeteer from Playwright #553

Open
MurakamiShinyu opened this issue Jan 12, 2025 · 4 comments
Open

Consider switching back to Puppeteer from Playwright #553

MurakamiShinyu opened this issue Jan 12, 2025 · 4 comments

Comments

@MurakamiShinyu
Copy link
Member

We switched from Puppeteer to Playwright in Vivliostyle CLI v5.0.0 (2022-06-06) because at that time Playwright had several advantages over Puppeteer.

See the pull request switching to Playwright:

Changed the headless browser library into Playwright. As a result of this, we can fix some of the significant issues of the current CLI.

  • Hung of launching headless browser (especially in CI)
  • Old Chromium on arm64 linux

And some features can be added!

  • Firefox & Webkit support (preview command only for now due to restriction of Playwright)
  • Global caching of the browser files

However, now most of the issues with Puppeteer have been resolved, and it has some advantages over Playwright, especially:

The only limitation of Puppeteer, as far as I know, is that it does not support WebKit, but I don't think it is very important for Vivliostyle CLI only for previewing.

@spring-raining
Copy link
Member

There seems to be a rationale for switching to Puppeteer, but I would like to do some more research to decide implementation policy.
Whether we choose Puppeteer or Playwright, it would be even better to have a feature that would allow us to specify the browser version to install, as we may have problems in the future that depend on a particular browser build.

@MurakamiShinyu
Copy link
Member Author

@MurakamiShinyu
Copy link
Member Author

MurakamiShinyu commented Jan 22, 2025

About support for hyphens: auto, they seem to be adding it in Playwright v1.51.

About PDF generation with Firefox, I got an answer from Playwright team: (microsoft/playwright#34406 (comment))

No plans of this kind. Generating pdf is not about testing and I am not sure why more than one generator is required.

and the issue was closed as no plans.

@anghenfil
Copy link

Seems like they won't add hyphens: auto support before Playwright v1.52: microsoft/playwright#34375

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants