-
Notifications
You must be signed in to change notification settings - Fork 102
Reenable and improve preprocess dataset #472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sjmonson
merged 23 commits into
vllm-project:main
from
jaredoconnell:features/reenable-preprocess
Nov 25, 2025
Merged
Changes from 11 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
5c883fb
Reenable preprocess dataset
jaredoconnell 53a26eb
Move preprocess code to data/entrypoints.py
jaredoconnell 2bc1eee
Added tests for dataset preprocess command
jaredoconnell 3885ba1
Added test for prefix buckets
jaredoconnell 0b260c8
Added documentation for preprocess dataset
jaredoconnell 81fbbe8
Improve documentation and fix lint and type errors
jaredoconnell 11cf5d2
Merge branch 'main' into features/reenable-preprocess
jaredoconnell 6308e6a
Port tests from old dataset test file
jaredoconnell 08d9419
Fix linting errors
jaredoconnell f1857e0
Format docs
jaredoconnell c60f1f2
Remove extra whitespace at end of file
jaredoconnell 1eea713
Address review comments
jaredoconnell 77df1c8
Address review comments
jaredoconnell a227a50
Merge branch 'main' into features/reenable-preprocess
jaredoconnell 00ee570
Fix tests broken in prior commit
jaredoconnell 6366782
Fix linter errors
jaredoconnell 86bca8e
Remove unused field in SyntheticTextDatasetConfig
jaredoconnell e922b5b
Addressed review comments
jaredoconnell ab93473
Move most preprocess logic out of entrypoints file
jaredoconnell aeab22c
Merge branch 'main' into features/reenable-preprocess
jaredoconnell 1e74368
Made tests correctly reference moved code
jaredoconnell 9eda590
Fix quality linter error
jaredoconnell 88c2753
Merge branch 'main' into features/reenable-preprocess
sjmonson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.