Skip to content

Conversation

@Potabk
Copy link
Collaborator

@Potabk Potabk commented Nov 18, 2025

What this PR does / why we need it?

Upgrade vllm commit hash to a2981c42720a34b5abf59c4c14df701f8105d4cd

Does this PR introduce any user-facing change?

How was this patch tested?

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 18, 2025
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the vLLM commit hash for the main branch in the versioning policy documentation. While the change itself is straightforward, I've identified a potential maintainability issue. The commit hash, which seems to be related to CI configuration based on the PR title, is hardcoded. This could lead to inconsistencies between the documentation and the actual CI configuration. I've left a comment with a suggestion to use a substitution variable from conf.py to act as a single source of truth, which would improve the robustness of this configuration.

@Potabk Potabk added ready read for review ready-for-test start test by label for PR labels Nov 18, 2025
@Potabk
Copy link
Collaborator Author

Potabk commented Nov 19, 2025

@wangxiyuan @MengqingCao I'd like to use feature vllm-project/vllm@a2981c4, thank you very much

Copy link
Collaborator

@MengqingCao MengqingCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as all CI passed

@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Potabk Potabk closed this Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation merge-conflicts ready read for review ready-for-test start test by label for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants