Skip to content

Conversation

@MaoJianwei
Copy link

@MaoJianwei MaoJianwei commented Dec 1, 2025

Purpose

remove the --extra-index-url link, to fix the following error while downloading dependencies before building VLLM for CPU backend.

image image

Test Result

Download dependencies ok.
Build VLLM ok.

image image image
Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@chatgpt-codex-connector
Copy link

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.

@mergify mergify bot added the ci/build label Dec 1, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request resolves a dependency installation error for the CPU backend by removing the --extra-index-url option from requirements/cpu-build.txt and requirements/cpu.txt. While pip can support this option in requirements files, it was causing errors in the author's environment. Removing it makes the installation process more robust by relying on command-line flags or environment variables to specify the PyTorch package index, which is already the documented practice for this project. The change is correct and improves the consistency of the installation process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant